Changeset 52010 for trunk/tests/phpunit/tests/http/http.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/http/http.php (modified) (7 diffs)

trunk/tests/phpunit/tests/http/http.php

@@ -14 +14 @@
      * @covers WP_Http::make_absolute_url
      */
-    function test_make_absolute_url( $relative_url, $absolute_url, $expected ) {
+    public function test_make_absolute_url( $relative_url, $absolute_url, $expected ) {
         $actual = WP_Http::make_absolute_url( $relative_url, $absolute_url );
         $this->assertSame( $expected, $actual );
     }
 
-    function make_absolute_url_testcases() {
+    public function make_absolute_url_testcases() {
         // 0: The Location header, 1: The current URL, 3: The expected URL.
         return array(
@@ -75 +75 @@
      * @covers ::wp_parse_url
      */
-    function test_wp_parse_url( $url, $expected ) {
+    public function test_wp_parse_url( $url, $expected ) {
         $actual = wp_parse_url( $url );
         $this->assertSame( $expected, $actual );
     }
 
-    function parse_url_testcases() {
+    public function parse_url_testcases() {
         // 0: The URL, 1: The expected resulting structure.
         return array(
@@ -188 +188 @@
      * @covers ::wp_parse_url
      */
-    function test_wp_parse_url_with_default_component() {
+    public function test_wp_parse_url_with_default_component() {
         $actual = wp_parse_url( self::FULL_TEST_URL, -1 );
         $this->assertSame(
@@ -212 +212 @@
      * @covers ::wp_parse_url
      */
-    function test_wp_parse_url_with_component( $url, $component, $expected ) {
+    public function test_wp_parse_url_with_component( $url, $component, $expected ) {
         $actual = wp_parse_url( $url, $component );
         $this->assertSame( $expected, $actual );
     }
 
-    function parse_url_component_testcases() {
+    public function parse_url_component_testcases() {
         // 0: The URL, 1: The requested component, 2: The expected resulting structure.
         return array(
@@ -329 +329 @@
      * @covers ::_get_component_from_parsed_url_array
      */
-    function test_get_component_from_parsed_url_array( $url, $component, $expected ) {
+    public function test_get_component_from_parsed_url_array( $url, $component, $expected ) {
         $parts  = wp_parse_url( $url );
         $actual = _get_component_from_parsed_url_array( $parts, $component );
@@ -335 +335 @@
     }
 
-    function get_component_from_parsed_url_array_testcases() {
+    public function get_component_from_parsed_url_array_testcases() {
         // 0: A URL, 1: PHP URL constant, 2: The expected result.
         return array(
@@ -370 +370 @@
      * @covers ::_wp_translate_php_url_constant_to_key
      */
-    function test_wp_translate_php_url_constant_to_key( $input, $expected ) {
+    public function test_wp_translate_php_url_constant_to_key( $input, $expected ) {
         $actual = _wp_translate_php_url_constant_to_key( $input );
         $this->assertSame( $expected, $actual );
     }
 
-    function wp_translate_php_url_constant_to_key_testcases() {
+    public function wp_translate_php_url_constant_to_key_testcases() {
         // 0: PHP URL constant, 1: The expected result.
         return array(