Changeset 52010 for trunk/tests/phpunit/tests/image/dimensions.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/image/dimensions.php (modified) (12 diffs)

trunk/tests/phpunit/tests/image/dimensions.php

@@ -7 +7 @@
  */
 class Tests_Image_Dimensions extends WP_UnitTestCase {
-    function test_400x400_no_crop() {
+    public function test_400x400_no_crop() {
         // Landscape: resize 640x480 to fit 400x400: 400x300.
         $out = image_resize_dimensions( 640, 480, 400, 400, false );
@@ -19 +19 @@
     }
 
-    function test_400x0_no_crop() {
+    public function test_400x0_no_crop() {
         // Landscape: resize 640x480 to fit 400w: 400x300.
         $out = image_resize_dimensions( 640, 480, 400, 0, false );
@@ -31 +31 @@
     }
 
-    function test_0x400_no_crop() {
+    public function test_0x400_no_crop() {
         // Landscape: resize 640x480 to fit 400h: 533x400.
         $out = image_resize_dimensions( 640, 480, 0, 400, false );
@@ -43 +43 @@
     }
 
-    function test_800x800_no_crop() {
+    public function test_800x800_no_crop() {
         // Landscape: resize 640x480 to fit 800x800.
         $out = image_resize_dimensions( 640, 480, 800, 800, false );
@@ -55 +55 @@
     }
 
-    function test_800x0_no_crop() {
+    public function test_800x0_no_crop() {
         // Landscape: resize 640x480 to fit 800w.
         $out = image_resize_dimensions( 640, 480, 800, 0, false );
@@ -67 +67 @@
     }
 
-    function test_0x800_no_crop() {
+    public function test_0x800_no_crop() {
         // Landscape: resize 640x480 to fit 800h.
         $out = image_resize_dimensions( 640, 480, 0, 800, false );
@@ -81 +81 @@
     // Cropped versions.
 
-    function test_400x400_crop() {
+    public function test_400x400_crop() {
         // Landscape: crop 640x480 to fit 400x400: 400x400 taken from a 480x480 crop at (80. 0).
         $out = image_resize_dimensions( 640, 480, 400, 400, true );
@@ -93 +93 @@
     }
 
-    function test_400x0_crop() {
+    public function test_400x0_crop() {
         // Landscape: resize 640x480 to fit 400w: 400x300.
         $out = image_resize_dimensions( 640, 480, 400, 0, true );
@@ -105 +105 @@
     }
 
-    function test_0x400_crop() {
+    public function test_0x400_crop() {
         // Landscape: resize 640x480 to fit 400h: 533x400.
         $out = image_resize_dimensions( 640, 480, 0, 400, true );
@@ -117 +117 @@
     }
 
-    function test_400x500_crop() {
+    public function test_400x500_crop() {
         // Landscape: crop 640x480 to fit 400x500: 400x400 taken from a 480x480 crop at (80. 0).
         $out = image_resize_dimensions( 640, 480, 400, 500, true );
@@ -129 +129 @@
     }
 
-    function test_640x480() {
+    public function test_640x480() {
         // Crop 640x480 to fit 640x480 (no change).
         $out = image_resize_dimensions( 640, 480, 640, 480, true );
@@ -157 +157 @@
      * @ticket 19393
      */
-    function test_crop_anchors() {
+    public function test_crop_anchors() {
         // Landscape: crop 640x480 to fit 400x500: 400x400 taken from a 480x480 crop.
         // src_x = 0 (left), src_y = 0 (top).