Changeset 52010 for trunk/tests/phpunit/tests/image/functions.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/image/functions.php (modified) (8 diffs)

trunk/tests/phpunit/tests/image/functions.php

@@ -46 +46 @@
     }
 
-    function test_is_image_positive() {
+    public function test_is_image_positive() {
         // These are all image files recognized by PHP.
         $files = array(
@@ -76 +76 @@
     }
 
-    function test_is_image_negative() {
+    public function test_is_image_negative() {
         // These are actually image files but aren't recognized or usable by PHP.
         $files = array(
@@ -89 +89 @@
     }
 
-    function test_is_displayable_image_positive() {
+    public function test_is_displayable_image_positive() {
         // These are all usable in typical web browsers.
         $files = array(
@@ -123 +123 @@
     }
 
-    function test_is_displayable_image_negative() {
+    public function test_is_displayable_image_negative() {
         // These are image files but aren't suitable for web pages because of compatibility or size issues.
         $files = array(
@@ -148 +148 @@
      * @ticket 50833
      */
-    function test_is_gd_image_invalid_types() {
+    public function test_is_gd_image_invalid_types() {
         $this->assertFalse( is_gd_image( new stdClass() ) );
         $this->assertFalse( is_gd_image( array() ) );
@@ -162 +162 @@
      * @requires extension gd
      */
-    function test_is_gd_image_valid_types() {
+    public function test_is_gd_image_valid_types() {
         $this->assertTrue( is_gd_image( imagecreate( 5, 5 ) ) );
     }
@@ -427 +427 @@
     }
 
-    function mock_image_editor( $editors ) {
+    public function mock_image_editor( $editors ) {
         return array( 'WP_Image_Editor_Mock' );
     }
@@ -639 +639 @@
     }
 
-    function filter_fallback_intermediate_image_sizes( $fallback_sizes, $metadata ) {
+    public function filter_fallback_intermediate_image_sizes( $fallback_sizes, $metadata ) {
         // Add the 'test-size' to the list of fallback sizes.
         $fallback_sizes[] = 'test-size';