Changeset 52010 for trunk/tests/phpunit/tests/image/header.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/image/header.php (modified) (8 diffs)

trunk/tests/phpunit/tests/image/header.php

@@ -9 +9 @@
     public $custom_image_header;
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
         $this->custom_image_header = new Custom_Image_Header( '__return_null' );
     }
 
-    function test_header_image_has_correct_dimensions_with_max_width() {
+    public function test_header_image_has_correct_dimensions_with_max_width() {
         global $_wp_theme_features;
 
@@ -34 +34 @@
     }
 
-    function test_header_image_has_correct_dimensions_with_fixed() {
+    public function test_header_image_has_correct_dimensions_with_fixed() {
         global $_wp_theme_features;
 
@@ -54 +54 @@
     }
 
-    function test_header_image_has_correct_dimensions_with_flex_height() {
+    public function test_header_image_has_correct_dimensions_with_flex_height() {
         global $_wp_theme_features;
 
@@ -74 +74 @@
     }
 
-    function test_header_image_has_correct_dimensions_with_flex_width() {
+    public function test_header_image_has_correct_dimensions_with_flex_width() {
         global $_wp_theme_features;
 
@@ -94 +94 @@
     }
 
-    function test_header_image_has_correct_dimensions_with_flex_width_and_height() {
+    public function test_header_image_has_correct_dimensions_with_flex_width_and_height() {
         global $_wp_theme_features;
 
@@ -114 +114 @@
     }
 
-    function test_create_attachment_object() {
+    public function test_create_attachment_object() {
         $id = wp_insert_attachment(
             array(
@@ -133 +133 @@
     }
 
-    function test_insert_cropped_attachment() {
+    public function test_insert_cropped_attachment() {
         $id = wp_insert_attachment(
             array(
@@ -155 +155 @@
      * @ticket 21819
      */
-    function test_check_get_previous_crop() {
+    public function test_check_get_previous_crop() {
         $id = wp_insert_attachment(
             array(