Changeset 52010 for trunk/tests/phpunit/tests/image/meta.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/image/meta.php (modified) (7 diffs)

trunk/tests/phpunit/tests/image/meta.php

@@ -29 +29 @@
     }
 
-    function test_exif_d70() {
+    public function test_exif_d70() {
         // Exif from a Nikon D70.
         $out = wp_read_image_metadata( DIR_TESTDATA . '/images/2004-07-22-DSC_0008.jpg' );
@@ -45 +45 @@
     }
 
-    function test_exif_d70_mf() {
+    public function test_exif_d70_mf() {
         // Exif from a Nikon D70 - manual focus lens, so some data is unavailable.
         $out = wp_read_image_metadata( DIR_TESTDATA . '/images/2007-06-17DSC_4173.JPG' );
@@ -62 +62 @@
     }
 
-    function test_exif_d70_iptc() {
+    public function test_exif_d70_iptc() {
         // Exif from a Nikon D70 with IPTC data added later.
         $out = wp_read_image_metadata( DIR_TESTDATA . '/images/2004-07-22-DSC_0007.jpg' );
@@ -78 +78 @@
     }
 
-    function test_exif_fuji() {
+    public function test_exif_fuji() {
         // Exif from a Fuji FinePix S5600 (thanks Mark).
         $out = wp_read_image_metadata( DIR_TESTDATA . '/images/a2-small.jpg' );
@@ -98 +98 @@
      * @ticket 6571
      */
-    function test_exif_error() {
+    public function test_exif_error() {
         // https://core.trac.wordpress.org/ticket/6571
         // This triggers a warning mesage when reading the Exif block.
@@ -115 +115 @@
     }
 
-    function test_exif_no_data() {
+    public function test_exif_no_data() {
         // No Exif data in this image (from burningwell.org).
         $out = wp_read_image_metadata( DIR_TESTDATA . '/images/canola.jpg' );
@@ -134 +134 @@
      * @ticket 9417
      */
-    function test_utf8_iptc_tags() {
+    public function test_utf8_iptc_tags() {
         // Trilingual UTF-8 text in the ITPC caption-abstract field.
         $out = wp_read_image_metadata( DIR_TESTDATA . '/images/test-image-iptc.jpg' );