Changeset 52010 for trunk/tests/phpunit/tests/image/size.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/image/size.php (modified) (13 diffs)

trunk/tests/phpunit/tests/image/size.php

@@ -8 +8 @@
 class Tests_Image_Size extends WP_UnitTestCase {
 
-        function test_constrain_dims_zero() {
+        public function test_constrain_dims_zero() {
                 // No constraint - should have no effect.
                 $out = wp_constrain_dimensions( 640, 480, 0, 0 );
@@ -23 +23 @@
         }
 
-        function test_constrain_dims_smaller() {
+        public function test_constrain_dims_smaller() {
                 // Image size is smaller than the constraint - no effect.
                 $out = wp_constrain_dimensions( 500, 600, 1024, 768 );
@@ -35 +35 @@
         }
 
-        function test_constrain_dims_equal() {
+        public function test_constrain_dims_equal() {
                 // Image size is equal to the constraint - no effect.
                 $out = wp_constrain_dimensions( 1024, 768, 1024, 768 );
@@ -47 +47 @@
         }
 
-        function test_constrain_dims_larger() {
+        public function test_constrain_dims_larger() {
                 // Image size is larger than the constraint - result should be constrained.
                 $out = wp_constrain_dimensions( 1024, 768, 500, 600 );
@@ -69 +69 @@
         }
 
-        function test_constrain_dims_boundary() {
+        public function test_constrain_dims_boundary() {
                 // One dimension is larger than the constraint, one smaller - result should be constrained.
                 $out = wp_constrain_dimensions( 1024, 768, 500, 800 );
@@ -88 +88 @@
          * @expectedDeprecated wp_shrink_dimensions
          */
-        function test_shrink_dimensions_default() {
+        public function test_shrink_dimensions_default() {
                 $out = wp_shrink_dimensions( 640, 480 );
                 $this->assertSame( array( 128, 96 ), $out );
@@ -99 +99 @@
          * @expectedDeprecated wp_shrink_dimensions
          */
-        function test_shrink_dimensions_smaller() {
+        public function test_shrink_dimensions_smaller() {
                 // Image size is smaller than the constraint - no effect.
                 $out = wp_shrink_dimensions( 500, 600, 1024, 768 );
@@ -111 +111 @@
          * @expectedDeprecated wp_shrink_dimensions
          */
-        function test_shrink_dimensions_equal() {
+        public function test_shrink_dimensions_equal() {
                 // Image size is equal to the constraint - no effect.
                 $out = wp_shrink_dimensions( 500, 600, 500, 600 );
@@ -123 +123 @@
          * @expectedDeprecated wp_shrink_dimensions
          */
-        function test_shrink_dimensions_larger() {
+        public function test_shrink_dimensions_larger() {
                 // Image size is larger than the constraint - result should be constrained.
                 $out = wp_shrink_dimensions( 1024, 768, 500, 600 );
@@ -135 +135 @@
          * @expectedDeprecated wp_shrink_dimensions
          */
-        function test_shrink_dimensions_boundary() {
+        public function test_shrink_dimensions_boundary() {
                 // One dimension is larger than the constraint, one smaller - result should be constrained.
                 $out = wp_shrink_dimensions( 1024, 768, 500, 800 );
@@ -151 +151 @@
         }
 
-        function test_constrain_size_for_editor_thumb() {
+        public function test_constrain_size_for_editor_thumb() {
                 $out = image_constrain_size_for_editor( 600, 400, 'thumb' );
                 $this->assertSame( array( 150, 100 ), $out );
@@ -159 +159 @@
         }
 
-        function test_constrain_size_for_editor_medium() {
+        public function test_constrain_size_for_editor_medium() {
                 // Default max width is 500, no constraint on height.
                 global $content_width;
@@ -186 +186 @@
         }
 
-        function test_constrain_size_for_editor_full() {
+        public function test_constrain_size_for_editor_full() {
                 global $content_width;