Changeset 52010 for trunk/tests/phpunit/tests/import/parser.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/import/parser.php (modified) (7 diffs)

trunk/tests/phpunit/tests/import/parser.php

@@ -7 +7 @@
  */
 class Tests_Import_Parser extends WP_Import_UnitTestCase {
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -25 +25 @@
     }
 
-    function test_malformed_wxr() {
+    public function test_malformed_wxr() {
         $file = DIR_TESTDATA . '/export/malformed.xml';
 
@@ -37 +37 @@
     }
 
-    function test_invalid_wxr() {
+    public function test_invalid_wxr() {
         $f1 = DIR_TESTDATA . '/export/missing-version-tag.xml';
         $f2 = DIR_TESTDATA . '/export/invalid-version-tag.xml';
@@ -51 +51 @@
     }
 
-    function test_wxr_version_1_1() {
+    public function test_wxr_version_1_1() {
         $file = DIR_TESTDATA . '/export/valid-wxr-1.1.xml';
 
@@ -144 +144 @@
     }
 
-    function test_wxr_version_1_0() {
+    public function test_wxr_version_1_0() {
         $file = DIR_TESTDATA . '/export/valid-wxr-1.0.xml';
 
@@ -238 +238 @@
      * @link https://core.trac.wordpress.org/ticket/15203
      */
-    function test_escaped_cdata_closing_sequence() {
+    public function test_escaped_cdata_closing_sequence() {
         $file = DIR_TESTDATA . '/export/crazy-cdata-escaped.xml';
 
@@ -271 +271 @@
      * with "]]>" unescaped within a CDATA section).
      */
-    function test_unescaped_cdata_closing_sequence() {
+    public function test_unescaped_cdata_closing_sequence() {
         $file = DIR_TESTDATA . '/export/crazy-cdata.xml';