Changeset 52010 for trunk/tests/phpunit/tests/includes/helpers.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/includes/helpers.php (modified) (4 diffs)

trunk/tests/phpunit/tests/includes/helpers.php

@@ -8 +8 @@
      * @ticket 30522
      */
-    function data_assertSameSets() {
+    public function data_assertSameSets() {
         return array(
             array(
@@ -52 +52 @@
      * @ticket 30522
      */
-    function test_assertSameSets( $expected, $actual, $exception ) {
+    public function test_assertSameSets( $expected, $actual, $exception ) {
         if ( $exception ) {
             try {
@@ -69 +69 @@
      * @ticket 30522
      */
-    function data_assertSameSetsWithIndex() {
+    public function data_assertSameSetsWithIndex() {
         return array(
             array(
@@ -208 +208 @@
      * @ticket 30522
      */
-    function test_assertSameSetsWithIndex( $expected, $actual, $exception ) {
+    public function test_assertSameSetsWithIndex( $expected, $actual, $exception ) {
         if ( $exception ) {
             try {