Changeset 52010 for trunk/tests/phpunit/tests/l10n/loadTextdomain.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/l10n/loadTextdomain.php (modified) (5 diffs)

trunk/tests/phpunit/tests/l10n/loadTextdomain.php

@@ -110 +110 @@
      * @ticket 21319
      */
-    function test_is_textdomain_is_not_loaded_after_gettext_call_with_no_translations() {
+    public function test_is_textdomain_is_not_loaded_after_gettext_call_with_no_translations() {
         $this->assertFalse( is_textdomain_loaded( 'wp-tests-domain' ) );
         __( 'just some string', 'wp-tests-domain' );
@@ -116 +116 @@
     }
 
-    function test_override_load_textdomain_noop() {
+    public function test_override_load_textdomain_noop() {
         add_filter( 'override_load_textdomain', '__return_true' );
         $load_textdomain = load_textdomain( 'wp-tests-domain', DIR_TESTDATA . '/non-existent-file' );
@@ -125 +125 @@
     }
 
-    function test_override_load_textdomain_non_existent_mofile() {
-        add_filter( 'override_load_textdomain', array( $this, '_override_load_textdomain_filter' ), 10, 3 );
+    public function test_override_load_textdomain_non_existent_mofile() {
+        add_filter( 'override_load_textdomain', array( $this, 'override_load_textdomain_filter' ), 10, 3 );
         $load_textdomain = load_textdomain( 'wp-tests-domain', WP_LANG_DIR . '/non-existent-file.mo' );
-        remove_filter( 'override_load_textdomain', array( $this, '_override_load_textdomain_filter' ) );
+        remove_filter( 'override_load_textdomain', array( $this, 'override_load_textdomain_filter' ) );
 
         $is_textdomain_loaded = is_textdomain_loaded( 'wp-tests-domain' );
@@ -139 +139 @@
     }
 
-    function test_override_load_textdomain_custom_mofile() {
-        add_filter( 'override_load_textdomain', array( $this, '_override_load_textdomain_filter' ), 10, 3 );
+    public function test_override_load_textdomain_custom_mofile() {
+        add_filter( 'override_load_textdomain', array( $this, 'override_load_textdomain_filter' ), 10, 3 );
         $load_textdomain = load_textdomain( 'wp-tests-domain', WP_LANG_DIR . '/plugins/internationalized-plugin-de_DE.mo' );
-        remove_filter( 'override_load_textdomain', array( $this, '_override_load_textdomain_filter' ) );
+        remove_filter( 'override_load_textdomain', array( $this, 'override_load_textdomain_filter' ) );
 
         $is_textdomain_loaded = is_textdomain_loaded( 'wp-tests-domain' );
@@ -159 +159 @@
      * @return bool
      */
-    function _override_load_textdomain_filter( $override, $domain, $file ) {
+    public function override_load_textdomain_filter( $override, $domain, $file ) {
         global $l10n;