Changeset 52010 for trunk/tests/phpunit/tests/link.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/link.php (modified) (5 diffs)

trunk/tests/phpunit/tests/link.php

@@ -5 +5 @@
 class Tests_Link extends WP_UnitTestCase {
 
-    function _get_pagenum_link_cb( $url ) {
+    public function get_pagenum_link_cb( $url ) {
         return $url . '/WooHoo';
     }
@@ -12 +12 @@
      * @ticket 8847
      */
-    function test_get_pagenum_link_case_insensitivity() {
+    public function test_get_pagenum_link_case_insensitivity() {
         $old_req_uri = $_SERVER['REQUEST_URI'];
 
         $this->set_permalink_structure( '/%year%/%monthnum%/%day%/%postname%/' );
 
-        add_filter( 'home_url', array( $this, '_get_pagenum_link_cb' ) );
+        add_filter( 'home_url', array( $this, 'get_pagenum_link_cb' ) );
         $_SERVER['REQUEST_URI'] = '/woohoo';
         $paged                  = get_pagenum_link( 2 );
 
-        remove_filter( 'home_url', array( $this, '_get_pagenum_link_cb' ) );
+        remove_filter( 'home_url', array( $this, 'get_pagenum_link_cb' ) );
         $this->assertSame( $paged, home_url( '/WooHoo/page/2/' ) );
 
@@ -27 +27 @@
     }
 
-    function test_wp_get_shortlink() {
+    public function test_wp_get_shortlink() {
         $post_id  = self::factory()->post->create();
         $post_id2 = self::factory()->post->create();
@@ -71 +71 @@
     }
 
-    function test_wp_get_shortlink_with_page() {
+    public function test_wp_get_shortlink_with_page() {
         $post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
 
@@ -86 +86 @@
      * @ticket 26871
      */
-    function test_wp_get_shortlink_with_home_page() {
+    public function test_wp_get_shortlink_with_home_page() {
         $post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
         update_option( 'show_on_front', 'page' );