Changeset 52010 for trunk/tests/phpunit/tests/menu/nav-menu.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/menu/nav-menu.php (modified) (10 diffs)

trunk/tests/phpunit/tests/menu/nav-menu.php

@@ -9 +9 @@
          * Set up.
          */
-        function set_up() {
+        public function set_up() {
                 parent::set_up();
 
@@ -23 +23 @@
          * @param array $locations Location slugs.
          */
-        function register_nav_menu_locations( $locations ) {
+        private function register_nav_menu_locations( $locations ) {
                 foreach ( $locations as $location ) {
                         register_nav_menu( $location, ucfirst( $location ) );
@@ -34 +34 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_one_location_each() {
+        public function test_one_location_each() {
                 $this->register_nav_menu_locations( array( 'primary' ) );
                 $prev_theme_nav_menu_locations     = array(
@@ -53 +53 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_filter_registered_locations() {
+        public function test_filter_registered_locations() {
                 $this->register_nav_menu_locations( array( 'primary', 'secondary' ) );
                 $prev_theme_nav_menu_locations     = array(
@@ -75 +75 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_locations_with_same_slug() {
+        public function test_locations_with_same_slug() {
                 $this->register_nav_menu_locations( array( 'primary', 'secondary' ) );
                 $prev_theme_nav_menu_locations = array(
@@ -94 +94 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_new_theme_previously_active() {
+        public function test_new_theme_previously_active() {
                 $this->register_nav_menu_locations( array( 'primary' ) );
 
@@ -118 +118 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_location_guessing() {
+        public function test_location_guessing() {
                 $this->register_nav_menu_locations( array( 'primary', 'secondary' ) );
 
@@ -141 +141 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_location_guessing_one_menu_per_group() {
+        public function test_location_guessing_one_menu_per_group() {
                 $this->register_nav_menu_locations( array( 'primary' ) );
                 $prev_theme_nav_menu_locations = array(
@@ -162 +162 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_location_guessing_one_menu_per_location() {
+        public function test_location_guessing_one_menu_per_location() {
                 $this->register_nav_menu_locations( array( 'primary', 'main' ) );
 
@@ -187 +187 @@
          * @covers ::wp_map_nav_menu_locations
          */
-        function test_numerical_locations() {
+        public function test_numerical_locations() {
                 $this->register_nav_menu_locations( array( 'primary', 1 ) );