Changeset 52010 for trunk/tests/phpunit/tests/meta.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/meta.php (modified) (14 diffs)

trunk/tests/phpunit/tests/meta.php

@@ -7 +7 @@
         protected $updated_mids = array();
 
-        function set_up() {
+        public function set_up() {
                 parent::set_up();
                 $this->author         = new WP_User( self::factory()->user->create( array( 'role' => 'author' ) ) );
@@ -14 +14 @@
         }
 
-        function _meta_sanitize_cb( $meta_value, $meta_key, $meta_type ) {
+        public function meta_sanitize_cb( $meta_value, $meta_key, $meta_type ) {
                 return 'sanitized';
         }
 
-        function test_sanitize_meta() {
+        public function test_sanitize_meta() {
                 $meta = sanitize_meta( 'some_meta', 'unsanitized', 'post' );
                 $this->assertSame( 'unsanitized', $meta );
 
-                register_meta( 'post', 'some_meta', array( $this, '_meta_sanitize_cb' ) );
+                register_meta( 'post', 'some_meta', array( $this, 'meta_sanitize_cb' ) );
                 $meta = sanitize_meta( 'some_meta', 'unsanitized', 'post' );
                 $this->assertSame( 'sanitized', $meta );
         }
 
-        function test_delete_metadata_by_mid() {
+        public function test_delete_metadata_by_mid() {
                 // Let's try and delete a non-existing ID, non existing meta.
                 $this->assertFalse( delete_metadata_by_mid( 'user', 0 ) );
@@ -42 +42 @@
         }
 
-        function test_update_metadata_by_mid() {
+        public function test_update_metadata_by_mid() {
                 // Setup.
                 $meta = get_metadata_by_mid( 'user', $this->meta_id );
@@ -105 +105 @@
         }
 
-        function test_metadata_exists() {
+        public function test_metadata_exists() {
                 $this->assertFalse( metadata_exists( 'user', $this->author->ID, 'foobarbaz' ) );
                 $this->assertTrue( metadata_exists( 'user', $this->author->ID, 'meta_key' ) );
@@ -115 +115 @@
          * @ticket 22746
          */
-        function test_metadata_exists_with_filter() {
+        public function test_metadata_exists_with_filter() {
                 // Let's see if it returns the correct value when adding a filter.
                 add_filter( 'get_user_metadata', '__return_zero' );
@@ -126 +126 @@
          * @ticket 18158
          */
-        function test_user_metadata_not_exists() {
+        public function test_user_metadata_not_exists() {
                 $u = get_users(
                         array(
@@ -199 +199 @@
         }
 
-        function test_metadata_slashes() {
+        public function test_metadata_slashes() {
                 $key       = __FUNCTION__;
                 $value     = 'Test\\singleslash';
@@ -232 +232 @@
          * @ticket 16814
          */
-        function test_meta_type_cast() {
+        public function test_meta_type_cast() {
                 $post_id1 = self::factory()->post->create();
                 add_post_meta( $post_id1, 'num_as_longtext', 123 );
@@ -302 +302 @@
         }
 
-        function test_meta_cache_order_asc() {
+        public function test_meta_cache_order_asc() {
                 $post_id = self::factory()->post->create();
                 $colors  = array( 'red', 'blue', 'yellow', 'green' );
@@ -322 +322 @@
          * @ticket 28315
          */
-        function test_non_numeric_object_id() {
+        public function test_non_numeric_object_id() {
                 $this->assertFalse( add_metadata( 'user', array( 1 ), 'meta_key', 'meta_value' ) );
                 $this->assertFalse( update_metadata( 'user', array( 1 ), 'meta_key', 'meta_new_value' ) );
@@ -333 +333 @@
          * @ticket 28315
          */
-        function test_non_numeric_meta_id() {
+        public function test_non_numeric_meta_id() {
                 $this->assertFalse( get_metadata_by_mid( 'user', array( 1 ) ) );
                 $this->assertFalse( update_metadata_by_mid( 'user', array( 1 ), 'meta_new_value' ) );
@@ -342 +342 @@
          * @ticket 37746
          */
-        function test_negative_meta_id() {
+        public function test_negative_meta_id() {
                 $negative_mid = $this->meta_id * -1;
 
@@ -354 +354 @@
          * @ticket 37746
          */
-        function test_floating_meta_id() {
+        public function test_floating_meta_id() {
                 $floating_mid = $this->meta_id + 0.1337;
 
@@ -366 +366 @@
          * @ticket 37746
          */
-        function test_string_point_zero_meta_id() {
+        public function test_string_point_zero_meta_id() {
                 $meta_id = add_metadata( 'user', $this->author->ID, 'meta_key', 'meta_value_2' );