WordPress.org
Get WordPress

Make WordPress Core


Ignore:
Timestamp:
11/04/2021 03:22:47 PM (3 years ago)
Author:
hellofromTonya
Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:
1 edited

Legend:

Unmodified
Added
Removed

  • trunk/tests/phpunit/tests/multisite/isUploadSpaceAvailable.php

    r51869 r52010  
    2626            delete_site_option( 'blog_upload_space' );
    2727
    28             add_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     28            add_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    2929            $available = is_upload_space_available();
    30             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     30            remove_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    3131
    3232            $this->assertTrue( $available );
    … …  
    3737            update_site_option( 'upload_space_check_disabled', true );
    3838
    39             add_filter( 'pre_get_space_used', array( $this, '_filter_space_used_large' ) );
     39            add_filter( 'pre_get_space_used', array( $this, 'filter_space_used_large' ) );
    4040            $available = is_upload_space_available();
    41             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used_large' ) );
     41            remove_filter( 'pre_get_space_used', array( $this, 'filter_space_used_large' ) );
    4242
    4343            $this->assertTrue( $available );
    … …  
    4747            update_option( 'blog_upload_space', 350 );
    4848
    49             add_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     49            add_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    5050            $available = is_upload_space_available();
    51             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     51            remove_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    5252
    5353            $this->assertTrue( $available );
    5454        }
    5555
    56         function test_is_upload_space_available_space_used_is_more_than_allowed() {
     56        public function test_is_upload_space_available_space_used_is_more_than_allowed() {
    5757            update_option( 'blog_upload_space', 350 );
    5858
    59             add_filter( 'pre_get_space_used', array( $this, '_filter_space_used_large' ) );
     59            add_filter( 'pre_get_space_used', array( $this, 'filter_space_used_large' ) );
    6060            $available = is_upload_space_available();
    61             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used_large' ) );
     61            remove_filter( 'pre_get_space_used', array( $this, 'filter_space_used_large' ) );
    6262
    6363            $this->assertFalse( $available );
    … …  
    6868         * for `get_space_allowed()`. We cover one scenario here.
    6969         */
    70         function test_is_upload_space_available_upload_space_0_defaults_to_100() {
     70        public function test_is_upload_space_available_upload_space_0_defaults_to_100() {
    7171            update_option( 'blog_upload_space', 0 );
    7272
    73             add_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     73            add_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    7474            $available = is_upload_space_available();
    75             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     75            remove_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    7676
    7777            $this->assertFalse( $available );
    7878        }
    7979
    80         function test_is_upload_space_available_upload_space_negative() {
     80        public function test_is_upload_space_available_upload_space_negative() {
    8181            update_site_option( 'blog_upload_space', -1 );
    8282
    83             add_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     83            add_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    8484            $available = is_upload_space_available();
    85             remove_filter( 'pre_get_space_used', array( $this, '_filter_space_used_small' ) );
     85            remove_filter( 'pre_get_space_used', array( $this, 'filter_space_used_small' ) );
    8686
    8787            $this->assertFalse( $available );
    8888        }
    8989
    90         function _filter_space_used_large() {
     90        public function filter_space_used_large() {
    9191            return 10000000;
    9292        }
    9393
    94         function _filter_space_used_small() {
     94        public function filter_space_used_small() {
    9595            return 10;
    9696        }
Note: See TracChangeset for help on using the changeset viewer.