Changeset 52010 for trunk/tests/phpunit/tests/multisite/updateBlogDetails.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/multisite/updateBlogDetails.php (modified) (5 diffs)

trunk/tests/phpunit/tests/multisite/updateBlogDetails.php

@@ -12 +12 @@
                  * should return false.
                  */
-                function test_update_blog_details_with_empty_args() {
+                public function test_update_blog_details_with_empty_args() {
                         $result = update_blog_details( 1, array() );
                         $this->assertFalse( $result );
@@ -20 +20 @@
                  * If the ID passed is not that of a current site, we should expect false.
                  */
-                function test_update_blog_details_invalid_blog_id() {
+                public function test_update_blog_details_invalid_blog_id() {
                         $result = update_blog_details( 999, array( 'domain' => 'example.com' ) );
                         $this->assertFalse( $result );
                 }
 
-                function test_update_blog_details() {
+                public function test_update_blog_details() {
                         $blog_id = self::factory()->blog->create();
 
@@ -67 +67 @@
                         }
 
-                        add_action( $hook, array( $this, '_action_counter_cb' ), 10 );
+                        add_action( $hook, array( $this, 'action_counter_cb' ), 10 );
 
                         update_blog_details( $blog_id, array( $flag => $flag_value ) );
@@ -83 +83 @@
                         $this->assertSame( 1, $test_action_counter );
 
-                        remove_action( $hook, array( $this, '_action_counter_cb' ), 10 );
+                        remove_action( $hook, array( $this, 'action_counter_cb' ), 10 );
                 }
 
@@ -102 +102 @@
                  * Provide a counter to determine that hooks are firing when intended.
                  */
-                function _action_counter_cb() {
+                public function action_counter_cb() {
                         global $test_action_counter;
                         $test_action_counter++;