Changeset 52010 for trunk/tests/phpunit/tests/oembed/controller.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/oembed/controller.php (modified) (17 diffs)

trunk/tests/phpunit/tests/oembed/controller.php

@@ -176 +176 @@
         }
 
-        function test_wp_oembed_ensure_format() {
+        public function test_wp_oembed_ensure_format() {
                 $this->assertSame( 'json', wp_oembed_ensure_format( 'json' ) );
                 $this->assertSame( 'xml', wp_oembed_ensure_format( 'xml' ) );
@@ -184 +184 @@
         }
 
-        function test_oembed_create_xml() {
+        public function test_oembed_create_xml() {
                 $actual = _oembed_create_xml(
                         array(
@@ -261 +261 @@
         }
 
-        function test_request_with_wrong_method() {
+        public function test_request_with_wrong_method() {
                 $request = new WP_REST_Request( 'POST', '/oembed/1.0/embed' );
 
@@ -270 +270 @@
         }
 
-        function test_request_without_url_param() {
+        public function test_request_without_url_param() {
                 $request = new WP_REST_Request( 'GET', '/oembed/1.0/embed' );
 
@@ -280 +280 @@
         }
 
-        function test_request_with_bad_url() {
+        public function test_request_with_bad_url() {
                 $request = new WP_REST_Request( 'GET', '/oembed/1.0/embed' );
                 $request->set_param( 'url', 'http://google.com/' );
@@ -290 +290 @@
         }
 
-        function test_request_invalid_format() {
+        public function test_request_invalid_format() {
                 $post_id = $this->factory()->post->create();
 
@@ -304 +304 @@
         }
 
-        function test_request_json() {
+        public function test_request_json() {
                 $user = self::factory()->user->create_and_get(
                         array(
@@ -349 +349 @@
          * @ticket 34971
          */
-        function test_request_static_front_page() {
+        public function test_request_static_front_page() {
                 $post = self::factory()->post->create_and_get(
                         array(
@@ -391 +391 @@
         }
 
-        function test_request_xml() {
+        public function test_request_xml() {
                 $user = self::factory()->user->create_and_get(
                         array(
@@ -438 +438 @@
          * @group ms-required
          */
-        function test_request_ms_child_in_root_blog() {
+        public function test_request_ms_child_in_root_blog() {
                 $child = self::factory()->blog->create();
                 switch_to_blog( $child );
@@ -461 +461 @@
         }
 
-        function test_rest_pre_serve_request() {
+        public function test_rest_pre_serve_request() {
                 $user = $this->factory()->user->create_and_get(
                         array(
@@ -485 +485 @@
         }
 
-        function test_rest_pre_serve_request_wrong_format() {
+        public function test_rest_pre_serve_request_wrong_format() {
                 $post = $this->factory()->post->create_and_get();
 
@@ -497 +497 @@
         }
 
-        function test_rest_pre_serve_request_wrong_method() {
+        public function test_rest_pre_serve_request_wrong_method() {
                 $post = $this->factory()->post->create_and_get();
 
@@ -509 +509 @@
         }
 
-        function test_get_oembed_endpoint_url() {
+        public function test_get_oembed_endpoint_url() {
                 $this->assertSame( home_url() . '/index.php?rest_route=/oembed/1.0/embed', get_oembed_endpoint_url() );
                 $this->assertSame( home_url() . '/index.php?rest_route=/oembed/1.0/embed', get_oembed_endpoint_url( '', 'json' ) );
@@ -522 +522 @@
         }
 
-        function test_get_oembed_endpoint_url_pretty_permalinks() {
+        public function test_get_oembed_endpoint_url_pretty_permalinks() {
                 update_option( 'permalink_structure', '/%postname%' );
 
@@ -675 +675 @@
          * @ticket 45142
          */
-        function test_proxy_with_internal_url() {
+        public function test_proxy_with_internal_url() {
                 wp_set_current_user( self::$editor );
 
@@ -723 +723 @@
          * @ticket 45142
          */
-        function test_proxy_with_static_front_page_url() {
+        public function test_proxy_with_static_front_page_url() {
                 wp_set_current_user( self::$editor );