Changeset 52010 for trunk/tests/phpunit/tests/oembed/discovery.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/oembed/discovery.php (modified) (5 diffs)

trunk/tests/phpunit/tests/oembed/discovery.php

@@ -5 +5 @@
  */
 class Tests_oEmbed_Discovery extends WP_UnitTestCase {
-    function test_add_oembed_discovery_links_non_singular() {
+    public function test_add_oembed_discovery_links_non_singular() {
         $this->assertSame( '', get_echo( 'wp_oembed_add_discovery_links' ) );
     }
 
-    function test_add_oembed_discovery_links_front_page() {
+    public function test_add_oembed_discovery_links_front_page() {
         $this->go_to( home_url() );
         $this->assertSame( '', get_echo( 'wp_oembed_add_discovery_links' ) );
@@ -18 +18 @@
      * @ticket 34971
      */
-    function test_add_oembed_discovery_links_static_front_page() {
+    public function test_add_oembed_discovery_links_static_front_page() {
         update_option( 'show_on_front', 'page' );
         update_option(
@@ -41 +41 @@
     }
 
-    function test_add_oembed_discovery_links_to_post() {
+    public function test_add_oembed_discovery_links_to_post() {
         $post_id = self::factory()->post->create();
         $this->go_to( get_permalink( $post_id ) );
@@ -52 +52 @@
     }
 
-    function test_add_oembed_discovery_links_to_page() {
+    public function test_add_oembed_discovery_links_to_page() {
         $post_id = self::factory()->post->create(
             array(
@@ -67 +67 @@
     }
 
-    function test_add_oembed_discovery_links_to_attachment() {
+    public function test_add_oembed_discovery_links_to_attachment() {
         $post_id       = self::factory()->post->create();
         $file          = DIR_TESTDATA . '/images/canola.jpg';