Changeset 52010 for trunk/tests/phpunit/tests/oembed/filterResult.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/oembed/filterResult.php (modified) (10 diffs)

trunk/tests/phpunit/tests/oembed/filterResult.php

@@ -5 +5 @@
  */
 class Tests_Filter_oEmbed_Result extends WP_UnitTestCase {
-    function test_filter_oembed_result_trusted_malicious_iframe() {
+    public function test_filter_oembed_result_trusted_malicious_iframe() {
         $html = '<p></p><iframe onload="alert(1)"></iframe>';
 
@@ -13 +13 @@
     }
 
-    function test_filter_oembed_result_with_untrusted_provider() {
+    public function test_filter_oembed_result_with_untrusted_provider() {
         $html   = '<p></p><iframe onload="alert(1)" src="http://example.com/sample-page/"></iframe>';
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), 'http://example.com/sample-page/' );
@@ -25 +25 @@
     }
 
-    function test_filter_oembed_result_only_one_iframe_is_allowed() {
+    public function test_filter_oembed_result_only_one_iframe_is_allowed() {
         $html   = '<div><iframe></iframe><iframe></iframe><p></p></div>';
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' );
@@ -32 +32 @@
     }
 
-    function test_filter_oembed_result_with_newlines() {
+    public function test_filter_oembed_result_with_newlines() {
         $html = <<<EOD
 <script>var = 1;</script>
@@ -45 +45 @@
     }
 
-    function test_filter_oembed_result_without_iframe() {
+    public function test_filter_oembed_result_without_iframe() {
         $html   = '<span>Hello</span><p>World</p>';
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' );
@@ -57 +57 @@
     }
 
-    function test_filter_oembed_result_secret_param_available() {
+    public function test_filter_oembed_result_secret_param_available() {
         $html   = '<iframe src="https://wordpress.org"></iframe>';
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' );
@@ -69 +69 @@
     }
 
-    function test_filter_oembed_result_wrong_type_provided() {
+    public function test_filter_oembed_result_wrong_type_provided() {
         $actual = wp_filter_oembed_result( 'some string', (object) array( 'type' => 'link' ), '' );
 
@@ -75 +75 @@
     }
 
-    function test_filter_oembed_result_invalid_result() {
+    public function test_filter_oembed_result_invalid_result() {
         $this->assertFalse( wp_filter_oembed_result( false, (object) array( 'type' => 'rich' ), '' ) );
         $this->assertFalse( wp_filter_oembed_result( '', (object) array( 'type' => 'rich' ), '' ) );
     }
 
-    function test_filter_oembed_result_blockquote_adds_style_to_iframe() {
+    public function test_filter_oembed_result_blockquote_adds_style_to_iframe() {
         $html   = '<blockquote></blockquote><iframe></iframe>';
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' );
@@ -87 +87 @@
     }
 
-    function test_filter_oembed_result_allowed_html() {
+    public function test_filter_oembed_result_allowed_html() {
         $html   = '<blockquote class="foo" id="bar"><strong><a href="" target=""></a></strong></blockquote><iframe></iframe>';
         $actual = wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' );
@@ -131 +131 @@
      * @group feed
      */
-    function test_filter_feed_content() {
+    public function test_filter_feed_content() {
         $html   = '<blockquote></blockquote><iframe></iframe>';
         $actual = _oembed_filter_feed_content( wp_filter_oembed_result( $html, (object) array( 'type' => 'rich' ), '' ) );