Changeset 52010 for trunk/tests/phpunit/tests/oembed/getResponseData.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/oembed/getResponseData.php (modified) (14 diffs)

trunk/tests/phpunit/tests/oembed/getResponseData.php

@@ -13 +13 @@
     }
 
-    function test_get_oembed_response_data_non_existent_post() {
+    public function test_get_oembed_response_data_non_existent_post() {
         $this->assertFalse( get_oembed_response_data( 0, 100 ) );
     }
 
-    function test_get_oembed_response_data() {
+    public function test_get_oembed_response_data() {
         $post = self::factory()->post->create_and_get(
             array(
@@ -46 +46 @@
      * Test get_oembed_response_data with an author.
      */
-    function test_get_oembed_response_data_author() {
+    public function test_get_oembed_response_data_author() {
         $user_id = self::factory()->user->create(
             array(
@@ -79 +79 @@
     }
 
-    function test_get_oembed_response_link() {
+    public function test_get_oembed_response_link() {
         remove_filter( 'oembed_response_data', 'get_oembed_response_data_rich' );
 
@@ -106 +106 @@
     }
 
-    function test_get_oembed_response_data_with_draft_post() {
+    public function test_get_oembed_response_data_with_draft_post() {
         $post = self::factory()->post->create_and_get(
             array(
@@ -116 +116 @@
     }
 
-    function test_get_oembed_response_data_with_scheduled_post() {
+    public function test_get_oembed_response_data_with_scheduled_post() {
         $post = self::factory()->post->create_and_get(
             array(
@@ -127 +127 @@
     }
 
-    function test_get_oembed_response_data_with_private_post() {
+    public function test_get_oembed_response_data_with_private_post() {
         $post = self::factory()->post->create_and_get(
             array(
@@ -140 +140 @@
      * @ticket 47574
      */
-    function test_get_oembed_response_data_with_public_true_custom_post_status() {
+    public function test_get_oembed_response_data_with_public_true_custom_post_status() {
         // Custom status with 'public' => true.
         register_post_status( 'public', array( 'public' => true ) );
@@ -156 +156 @@
      * @ticket 47574
      */
-    function test_get_oembed_response_data_with_public_false_custom_post_status() {
+    public function test_get_oembed_response_data_with_public_false_custom_post_status() {
         // Custom status with 'public' => false.
         register_post_status( 'private_foo', array( 'public' => false ) );
@@ -172 +172 @@
      * @ticket 47574
      */
-    function test_get_oembed_response_data_with_unregistered_custom_post_status() {
+    public function test_get_oembed_response_data_with_unregistered_custom_post_status() {
         $post = self::factory()->post->create_and_get(
             array(
@@ -182 +182 @@
     }
 
-    function test_get_oembed_response_data_maxwidth_too_high() {
+    public function test_get_oembed_response_data_maxwidth_too_high() {
         $post = self::factory()->post->create_and_get();
 
@@ -191 +191 @@
     }
 
-    function test_get_oembed_response_data_maxwidth_too_low() {
+    public function test_get_oembed_response_data_maxwidth_too_low() {
         $post = self::factory()->post->create_and_get();
 
@@ -200 +200 @@
     }
 
-    function test_get_oembed_response_data_maxwidth_invalid() {
+    public function test_get_oembed_response_data_maxwidth_invalid() {
         $post = self::factory()->post->create_and_get();
 
@@ -214 +214 @@
     }
 
-    function test_get_oembed_response_data_with_thumbnail() {
+    public function test_get_oembed_response_data_with_thumbnail() {
         $post          = self::factory()->post->create_and_get();
         $file          = DIR_TESTDATA . '/images/canola.jpg';
@@ -234 +234 @@
     }
 
-    function test_get_oembed_response_data_for_attachment() {
+    public function test_get_oembed_response_data_for_attachment() {
         $parent = self::factory()->post->create();
         $file   = DIR_TESTDATA . '/images/canola.jpg';