Changeset 52010 for trunk/tests/phpunit/tests/oembed/postEmbedUrl.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/oembed/postEmbedUrl.php (modified) (6 diffs)

trunk/tests/phpunit/tests/oembed/postEmbedUrl.php

@@ -5 +5 @@
  */
 class Tests_Post_Embed_URL extends WP_UnitTestCase {
-    function test_non_existent_post() {
+    public function test_non_existent_post() {
         $embed_url = get_post_embed_url( 0 );
         $this->assertFalse( $embed_url );
     }
 
-    function test_with_pretty_permalinks() {
+    public function test_with_pretty_permalinks() {
         $this->set_permalink_structure( '/%postname%' );
 
@@ -20 +20 @@
     }
 
-    function test_with_ugly_permalinks() {
+    public function test_with_ugly_permalinks() {
         $post_id   = self::factory()->post->create();
         $permalink = get_permalink( $post_id );
@@ -31 +31 @@
      * @ticket 34971
      */
-    function test_static_front_page() {
+    public function test_static_front_page() {
         $this->set_permalink_structure( '/%postname%/' );
 
@@ -49 +49 @@
      * @ticket 34971
      */
-    function test_static_front_page_with_ugly_permalinks() {
+    public function test_static_front_page_with_ugly_permalinks() {
         $post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
 
@@ -65 +65 @@
      * @ticket 34971
      */
-    function test_page_conflicts_with_embed_slug() {
+    public function test_page_conflicts_with_embed_slug() {
         $this->set_permalink_structure( '/%postname%/' );
 
@@ -87 +87 @@
      * @ticket 34971
      */
-    function test_static_front_page_conflicts_with_embed_slug() {
+    public function test_static_front_page_conflicts_with_embed_slug() {
         $this->set_permalink_structure( '/%postname%/' );