Changeset 52010 for trunk/tests/phpunit/tests/option/multisite.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/option/multisite.php (modified) (8 diffs)

trunk/tests/phpunit/tests/option/multisite.php

@@ -12 +12 @@
     class Tests_Multisite_Option extends WP_UnitTestCase {
 
-        function test_from_same_site() {
+        public function test_from_same_site() {
             $key    = __FUNCTION__ . '_1';
             $key2   = __FUNCTION__ . '_2';
@@ -49 +49 @@
         }
 
-        function test_from_same_site_with_null_blog_id() {
+        public function test_from_same_site_with_null_blog_id() {
             $key    = __FUNCTION__ . '_1';
             $key2   = __FUNCTION__ . '_2';
@@ -85 +85 @@
         }
 
-        function test_with_another_site() {
+        public function test_with_another_site() {
             $user_id = self::factory()->user->create();
             $this->assertIsInt( $user_id );
@@ -135 +135 @@
          * @group multisite
          */
-        function test_site_notoptions() {
+        public function test_site_notoptions() {
             $network_id     = get_current_network_id();
             $notoptions_key = "{$network_id}:notoptions";
@@ -152 +152 @@
         }
 
-        function test_users_can_register_signup_filter() {
+        public function test_users_can_register_signup_filter() {
 
             $registration = get_site_option( 'registration' );
@@ -170 +170 @@
          * @dataProvider data_illegal_names
          */
-        function test_sanitize_network_option_illegal_names( $option_value, $sanitized_option_value ) {
+        public function test_sanitize_network_option_illegal_names( $option_value, $sanitized_option_value ) {
             update_site_option( 'illegal_names', $option_value );
             $this->assertSame( $sanitized_option_value, get_site_option( 'illegal_names' ) );
         }
 
-        function data_illegal_names() {
+        public function data_illegal_names() {
             return array(
                 array( array( '', 'Woo', '' ), array( 'Woo' ) ),
@@ -189 +189 @@
          * @param $sanitized_option_value
          */
-        function test_sanitize_network_option_limited_email_domains( $option_value, $sanitized_option_value ) {
+        public function test_sanitize_network_option_limited_email_domains( $option_value, $sanitized_option_value ) {
             update_site_option( 'limited_email_domains', $option_value );
             $this->assertSame( $sanitized_option_value, get_site_option( 'limited_email_domains' ) );
@@ -200 +200 @@
          * @param $sanitized_option_value
          */
-        function test_sanitize_network_option_banned_email_domains( $option_value, $sanitized_option_value ) {
+        public function test_sanitize_network_option_banned_email_domains( $option_value, $sanitized_option_value ) {
             update_site_option( 'banned_email_domains', $option_value );
             $this->assertSame( $sanitized_option_value, get_site_option( 'banned_email_domains' ) );
         }
 
-        function data_email_domains() {
+        public function data_email_domains() {
             return array(
                 array( array( 'woo', '', 'boo.com', 'foo.net.biz..' ), array( 'woo', 'boo.com' ) ),