Changeset 52010 for trunk/tests/phpunit/tests/option/networkOption.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/option/networkOption.php (modified) (6 diffs)

trunk/tests/phpunit/tests/option/networkOption.php

@@ -16 +16 @@
      * @group ms-required
      */
-    function test_add_network_option_not_available_on_other_network() {
+    public function test_add_network_option_not_available_on_other_network() {
         $id     = self::factory()->network->create();
         $option = __FUNCTION__;
@@ -28 +28 @@
      * @group ms-required
      */
-    function test_add_network_option_available_on_same_network() {
+    public function test_add_network_option_available_on_same_network() {
         $id     = self::factory()->network->create();
         $option = __FUNCTION__;
@@ -40 +40 @@
      * @group ms-required
      */
-    function test_delete_network_option_on_only_one_network() {
+    public function test_delete_network_option_on_only_one_network() {
         $id     = self::factory()->network->create();
         $option = __FUNCTION__;
@@ -85 +85 @@
      * @param $expected_response
      */
-    function test_add_network_option_network_id_parameter( $network_id, $expected_response ) {
+    public function test_add_network_option_network_id_parameter( $network_id, $expected_response ) {
         $option = rand_str();
         $value  = rand_str();
@@ -98 +98 @@
      * @param $expected_response
      */
-    function test_get_network_option_network_id_parameter( $network_id, $expected_response ) {
+    public function test_get_network_option_network_id_parameter( $network_id, $expected_response ) {
         $option = rand_str();
 
@@ -104 +104 @@
     }
 
-    function data_network_id_parameter() {
+    public function data_network_id_parameter() {
         return array(
             // Numeric values should always be accepted.