Changeset 52010 for trunk/tests/phpunit/tests/option/option.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/option/option.php (modified) (6 diffs)

trunk/tests/phpunit/tests/option/option.php

@@ -6 +6 @@
 class Tests_Option_Option extends WP_UnitTestCase {
 
-        function __return_foo() {
+        public function __return_foo() {
                 return 'foo';
         }
 
-        function test_the_basics() {
+        public function test_the_basics() {
                 $key    = 'key1';
                 $key2   = 'key2';
@@ -35 +35 @@
         }
 
-        function test_default_filter() {
+        public function test_default_filter() {
                 $value = 'value';
 
@@ -72 +72 @@
         }
 
-        function test_serialized_data() {
+        public function test_serialized_data() {
                 $key   = __FUNCTION__;
                 $value = array(
@@ -212 +212 @@
          * @ticket 23289
          */
-        function test_special_option_name_alloption() {
+        public function test_special_option_name_alloption() {
                 $this->expectException( 'WPDieException' );
                 delete_option( 'alloptions' );
@@ -220 +220 @@
          * @ticket 23289
          */
-        function test_special_option_name_notoptions() {
+        public function test_special_option_name_notoptions() {
                 $this->expectException( 'WPDieException' );
                 delete_option( 'notoptions' );
         }
 
-        function data_option_autoloading() {
+        public function data_option_autoloading() {
                 return array(
                         array( 'autoload_yes', 'yes', 'yes' ),
@@ -242 +242 @@
          * @dataProvider data_option_autoloading
          */
-        function test_option_autoloading( $name, $autoload_value, $expected ) {
+        public function test_option_autoloading( $name, $autoload_value, $expected ) {
                 global $wpdb;
                 $added = add_option( $name, 'Autoload test', '', $autoload_value );