Changeset 52010 for trunk/tests/phpunit/tests/option/themeMods.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/option/themeMods.php (modified) (5 diffs)

trunk/tests/phpunit/tests/option/themeMods.php

@@ -6 +6 @@
 class Tests_Option_Theme_Mods extends WP_UnitTestCase {
 
-        function test_theme_mod_default() {
+        public function test_theme_mod_default() {
                 $this->assertFalse( get_theme_mod( 'non_existent' ) );
         }
 
-        function test_theme_mod_defined_default() {
+        public function test_theme_mod_defined_default() {
                 $this->assertSame( 'default', get_theme_mod( 'non_existent', 'default' ) );
         }
 
-        function test_theme_mod_set() {
+        public function test_theme_mod_set() {
                 $expected = 'value';
                 set_theme_mod( 'test_name', $expected );
@@ -23 +23 @@
          * @ticket 51423
          */
-        function test_theme_mod_set_with_invalid_theme_mods_option() {
+        public function test_theme_mod_set_with_invalid_theme_mods_option() {
                 $theme_slug = get_option( 'stylesheet' );
                 update_option( 'theme_mods_' . $theme_slug, '' );
@@ -29 +29 @@
         }
 
-        function test_theme_mod_update() {
+        public function test_theme_mod_update() {
                 set_theme_mod( 'test_update', 'first_value' );
                 $expected = 'updated_value';
@@ -36 +36 @@
         }
 
-        function test_theme_mod_remove() {
+        public function test_theme_mod_remove() {
                 set_theme_mod( 'test_remove', 'value' );
                 remove_theme_mod( 'test_remove' );
@@ -47 +47 @@
          * @dataProvider data_theme_mod_default_value_with_percent_symbols
          */
-        function test_theme_mod_default_value_with_percent_symbols( $default, $expected ) {
+        public function test_theme_mod_default_value_with_percent_symbols( $default, $expected ) {
                 $this->assertSame( $expected, get_theme_mod( 'test_name', $default ) );
         }
 
-        function data_theme_mod_default_value_with_percent_symbols() {
+        public function data_theme_mod_default_value_with_percent_symbols() {
                 return array(
                         array(