Changeset 52010 for trunk/tests/phpunit/tests/pomo/po.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/pomo/po.php (modified) (10 diffs)

trunk/tests/phpunit/tests/pomo/po.php

@@ -49 +49 @@
     }
 
-    function test_prepend_each_line() {
+    public function test_prepend_each_line() {
         $po = new PO();
         $this->assertSame( 'baba_', $po->prepend_each_line( '', 'baba_' ) );
@@ -56 +56 @@
     }
 
-    function test_poify() {
+    public function test_poify() {
         $po = new PO();
         // Simple.
@@ -75 +75 @@
     }
 
-    function test_unpoify() {
+    public function test_unpoify() {
         $po = new PO();
         $this->assertSame( 'baba', $po->unpoify( '"baba"' ) );
@@ -86 +86 @@
     }
 
-    function test_export_entry() {
+    public function test_export_entry() {
         $po    = new PO();
         $entry = new Translation_Entry( array( 'singular' => 'baba' ) );
@@ -211 +211 @@
     }
 
-    function test_export_entries() {
+    public function test_export_entries() {
         $entry  = new Translation_Entry( array( 'singular' => 'baba' ) );
         $entry2 = new Translation_Entry( array( 'singular' => 'dyado' ) );
@@ -220 +220 @@
     }
 
-    function test_export_headers() {
+    public function test_export_headers() {
         $po = new PO();
         $po->set_header( 'Project-Id-Version', 'WordPress 2.6-bleeding' );
@@ -227 +227 @@
     }
 
-    function test_export() {
+    public function test_export() {
         $po     = new PO();
         $entry  = new Translation_Entry( array( 'singular' => 'baba' ) );
@@ -240 +240 @@
 
 
-    function test_export_to_file() {
+    public function test_export_to_file() {
         $po     = new PO();
         $entry  = new Translation_Entry( array( 'singular' => 'baba' ) );
@@ -258 +258 @@
     }
 
-    function test_import_from_file() {
+    public function test_import_from_file() {
         $po  = new PO();
         $res = $po->import_from_file( DIR_TESTDATA . '/pomo/simple.po' );
@@ -317 +317 @@
     }
 
-    function test_import_from_entry_file_should_give_false() {
+    public function test_import_from_entry_file_should_give_false() {
         $po = new PO();
         $this->assertFalse( $po->import_from_file( DIR_TESTDATA . '/pomo/empty.po' ) );
     }
 
-    function test_import_from_file_with_windows_line_endings_should_work_as_with_unix_line_endings() {
+    public function test_import_from_file_with_windows_line_endings_should_work_as_with_unix_line_endings() {
         $po = new PO();
         $this->assertTrue( $po->import_from_file( DIR_TESTDATA . '/pomo/windows-line-endings.po' ) );