Changeset 52010 for trunk/tests/phpunit/tests/post/attachments.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/post/attachments.php (modified) (9 diffs)

trunk/tests/phpunit/tests/post/attachments.php

@@ -8 +8 @@
 class Tests_Post_Attachments extends WP_UnitTestCase {
 
-    function tear_down() {
+    public function tear_down() {
         // Remove all uploads.
         $this->remove_added_uploads();
@@ -14 +14 @@
     }
 
-    function test_insert_bogus_image() {
+    public function test_insert_bogus_image() {
         $filename = rand_str() . '.jpg';
         $contents = rand_str();
@@ -22 +22 @@
     }
 
-    function test_insert_image_no_thumb() {
+    public function test_insert_image_no_thumb() {
 
         // This image is smaller than the thumbnail size so it won't have one.
@@ -58 +58 @@
      * @requires function imagejpeg
      */
-    function test_insert_image_thumb_only() {
+    public function test_insert_image_thumb_only() {
         update_option( 'medium_size_w', 0 );
         update_option( 'medium_size_h', 0 );
@@ -109 +109 @@
      * @requires function imagejpeg
      */
-    function test_insert_image_medium_sizes() {
+    public function test_insert_image_medium_sizes() {
         update_option( 'medium_size_w', 400 );
         update_option( 'medium_size_h', 0 );
@@ -166 +166 @@
      * @requires function imagejpeg
      */
-    function test_insert_image_delete() {
+    public function test_insert_image_delete() {
         update_option( 'medium_size_w', 400 );
         update_option( 'medium_size_h', 0 );
@@ -214 +214 @@
      * @ticket 21963
      */
-    function test_insert_image_without_guid() {
+    public function test_insert_image_without_guid() {
         // This image is smaller than the thumbnail size so it won't have one.
         $filename = ( DIR_TESTDATA . '/images/test-image.jpg' );
@@ -232 +232 @@
      * @ticket 21963
      */
-    function test_update_attachment_fields() {
+    public function test_update_attachment_fields() {
         $filename = ( DIR_TESTDATA . '/images/test-image.jpg' );
         $contents = file_get_contents( $filename );
@@ -258 +258 @@
      * @ticket 29646
      */
-    function test_update_orphan_attachment_parent() {
+    public function test_update_orphan_attachment_parent() {
         $filename = ( DIR_TESTDATA . '/images/test-image.jpg' );
         $contents = file_get_contents( $filename );