Changeset 52010 for trunk/tests/phpunit/tests/post/output.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/post/output.php (modified) (8 diffs)

trunk/tests/phpunit/tests/post/output.php

@@ -9 +9 @@
 class Tests_Post_Output extends WP_UnitTestCase {
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
-        add_shortcode( 'dumptag', array( $this, '_shortcode_dumptag' ) );
-        add_shortcode( 'paragraph', array( $this, '_shortcode_paragraph' ) );
-    }
-
-    function tear_down() {
+        add_shortcode( 'dumptag', array( $this, 'shortcode_dumptag' ) );
+        add_shortcode( 'paragraph', array( $this, 'shortcode_paragraph' ) );
+    }
+
+    public function tear_down() {
         global $shortcode_tags;
         unset( $shortcode_tags['dumptag'], $shortcode_tags['paragraph'] );
@@ -21 +21 @@
     }
 
-    function _shortcode_dumptag( $atts ) {
+    public function shortcode_dumptag( $atts ) {
         $out = '';
         foreach ( $atts as $k => $v ) {
@@ -29 +29 @@
     }
 
-    function _shortcode_paragraph( $atts, $content ) {
+    public function shortcode_paragraph( $atts, $content ) {
         $processed_atts = shortcode_atts(
             array(
@@ -40 +40 @@
     }
 
-    function test_the_content() {
+    public function test_the_content() {
         $post_content = <<<EOF
 <i>This is the excerpt.</i>
@@ -63 +63 @@
     }
 
-    function test_the_content_shortcode() {
+    public function test_the_content_shortcode() {
         $post_content = <<<EOF
 [dumptag foo="bar" baz="123"]
@@ -91 +91 @@
     }
 
-    function test_the_content_shortcode_paragraph() {
+    public function test_the_content_shortcode_paragraph() {
         $post_content = <<<EOF
 Graf by itself:
@@ -129 +129 @@
     }
 
-    function test_the_content_attribute_filtering() {
+    public function test_the_content_attribute_filtering() {
         kses_init_filters();
 
@@ -153 +153 @@
     }
 
-    function test_the_content_attribute_value_with_colon() {
+    public function test_the_content_attribute_value_with_colon() {
         kses_init_filters();