Changeset 52010 for trunk/tests/phpunit/tests/post/query.php

Timestamp:

11/04/2021 03:22:47 PM (2 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/post/query.php (modified) (10 diffs)

trunk/tests/phpunit/tests/post/query.php

@@ -9 +9 @@
      * @group taxonomy
      */
-    function test_category__and_var() {
+    public function test_category__and_var() {
         $q = new WP_Query();
 
@@ -51 +51 @@
      * @group taxonomy
      */
-    function test_empty_category__in() {
+    public function test_empty_category__in() {
         $cat_id  = self::factory()->category->create();
         $post_id = self::factory()->post->create();
@@ -80 +80 @@
      * @ticket 22448
      */
-    function test_the_posts_filter() {
+    public function test_the_posts_filter() {
         // Create posts and clear their caches.
         $post_ids = self::factory()->post->create_many( 4 );
@@ -118 +118 @@
      * Use with the_posts filter, appends a post and adds some custom data.
      */
-    function the_posts_filter( $posts ) {
+    public function the_posts_filter( $posts ) {
         $posts[] = clone $posts[0];
 
@@ -129 +129 @@
     }
 
-    function test_post__in_ordering() {
+    public function test_post__in_ordering() {
         $post_id1 = self::factory()->post->create(
             array(
@@ -211 +211 @@
     }
 
-    function test_post__in_attachment_ordering() {
+    public function test_post__in_attachment_ordering() {
         $post_id    = self::factory()->post->create();
         $att_ids    = array();
@@ -309 +309 @@
     }
 
-    function test_post_status() {
+    public function test_post_status() {
         $statuses1 = get_post_stati();
         $this->assertContains( 'auto-draft', $statuses1 );
@@ -332 +332 @@
      * @ticket 17065
      */
-    function test_orderby_array() {
+    public function test_orderby_array() {
         global $wpdb;
 
@@ -368 +368 @@
      * @ticket 17065
      */
-    function test_order() {
+    public function test_order() {
         global $wpdb;
 
@@ -408 +408 @@
      * @ticket 29629
      */
-    function test_orderby() {
+    public function test_orderby() {
         // 'rand' is a valid value.
         $q = new WP_Query( array( 'orderby' => 'rand' ) );