Changeset 52010 for trunk/tests/phpunit/tests/post/thumbnails.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/post/thumbnails.php (modified) (20 diffs)

trunk/tests/phpunit/tests/post/thumbnails.php

@@ -32 +32 @@
     }
 
-    function test_has_post_thumbnail() {
+    public function test_has_post_thumbnail() {
         $this->assertFalse( has_post_thumbnail( self::$post ) );
         $this->assertFalse( has_post_thumbnail( self::$post->ID ) );
@@ -54 +54 @@
     }
 
-    function test_get_post_thumbnail_id() {
+    public function test_get_post_thumbnail_id() {
         $this->assertSame( 0, get_post_thumbnail_id( self::$post ) );
         $this->assertSame( 0, get_post_thumbnail_id( self::$post->ID ) );
@@ -69 +69 @@
     }
 
-    function test_update_post_thumbnail_cache() {
+    public function test_update_post_thumbnail_cache() {
         set_post_thumbnail( self::$post, self::$attachment_id );
 
@@ -90 +90 @@
      * @ticket 12235
      */
-    function test_get_the_post_thumbnail_caption() {
+    public function test_get_the_post_thumbnail_caption() {
         $this->assertSame( '', get_the_post_thumbnail_caption() );
 
@@ -114 +114 @@
      * @ticket 12235
      */
-    function test_get_the_post_thumbnail_caption_empty() {
+    public function test_get_the_post_thumbnail_caption_empty() {
         $post_id       = self::factory()->post->create();
         $attachment_id = self::factory()->attachment->create_object(
@@ -134 +134 @@
      * @ticket 12235
      */
-    function test_the_post_thumbnail_caption() {
+    public function test_the_post_thumbnail_caption() {
         $caption = 'This is a caption.';
 
@@ -154 +154 @@
     }
 
-    function test_get_the_post_thumbnail() {
+    public function test_get_the_post_thumbnail() {
         $this->assertSame( '', get_the_post_thumbnail() );
         $this->assertSame( '', get_the_post_thumbnail( self::$post ) );
@@ -175 +175 @@
     }
 
-    function test_the_post_thumbnail() {
+    public function test_the_post_thumbnail() {
 
         $this->expectOutputString( '' );
@@ -203 +203 @@
      * @ticket 33070
      */
-    function test_get_the_post_thumbnail_url() {
+    public function test_get_the_post_thumbnail_url() {
         $this->assertFalse( has_post_thumbnail( self::$post ) );
         $this->assertFalse( get_the_post_thumbnail_url() );
@@ -221 +221 @@
      * @ticket 33070
      */
-    function test_get_the_post_thumbnail_url_with_invalid_post() {
+    public function test_get_the_post_thumbnail_url_with_invalid_post() {
         set_post_thumbnail( self::$post, self::$attachment_id );
 
@@ -235 +235 @@
      * @ticket 33070
      */
-    function test_the_post_thumbnail_url() {
+    public function test_the_post_thumbnail_url() {
         $GLOBALS['post'] = self::$post;
 
@@ -250 +250 @@
      * @ticket 12922
      */
-    function test__wp_preview_post_thumbnail_filter() {
+    public function test__wp_preview_post_thumbnail_filter() {
         $old_post = isset( $GLOBALS['post'] ) ? $GLOBALS['post'] : null;
 
@@ -270 +270 @@
      * @ticket 37697
      */
-    function test__wp_preview_post_thumbnail_filter_secondary_post() {
+    public function test__wp_preview_post_thumbnail_filter_secondary_post() {
         $old_post = isset( $GLOBALS['post'] ) ? $GLOBALS['post'] : null;
 
@@ -296 +296 @@
      * @ticket 12922
      */
-    function test_insert_post_with_post_thumbnail() {
+    public function test_insert_post_with_post_thumbnail() {
         $post_id = wp_insert_post(
             array(
@@ -327 +327 @@
      * @ticket 37658
      */
-    function test_insert_attachment_with_post_thumbnail() {
+    public function test_insert_attachment_with_post_thumbnail() {
         // Audio files support featured images.
         $post_id = wp_insert_post(
@@ -366 +366 @@
      * @ticket 39030
      */
-    function test_post_thumbnail_size_filter_simple() {
+    public function test_post_thumbnail_size_filter_simple() {
         $this->current_size_filter_data = 'medium';
 
@@ -387 +387 @@
      * @dataProvider data_post_thumbnail_size_filter_complex
      */
-    function test_post_thumbnail_size_filter_complex( $which_post, $expected ) {
+    public function test_post_thumbnail_size_filter_complex( $which_post, $expected ) {
         $this->current_size_filter_data = array(
             self::$post->ID           => 'medium',
@@ -409 +409 @@
     }
 
-    function data_post_thumbnail_size_filter_complex() {
+    public function data_post_thumbnail_size_filter_complex() {
         return array(
             array( 0, 'medium' ),
@@ -416 +416 @@
     }
 
-    function filter_post_thumbnail_size( $size, $post_id ) {
+    public function filter_post_thumbnail_size( $size, $post_id ) {
         if ( is_array( $this->current_size_filter_data ) && isset( $this->current_size_filter_data[ $post_id ] ) ) {
             return $this->current_size_filter_data[ $post_id ];
@@ -428 +428 @@
     }
 
-    function filter_set_post_thumbnail_size_result( $html, $post_id, $post_thumbnail_id, $size ) {
+    public function filter_set_post_thumbnail_size_result( $html, $post_id, $post_thumbnail_id, $size ) {
         $this->current_size_filter_result = $size;