Changeset 52010 for trunk/tests/phpunit/tests/post/types.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/post/types.php (modified) (15 diffs)

trunk/tests/phpunit/tests/post/types.php

@@ -19 +19 @@
      * @since 4.5.0
      */
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -25 +25 @@
     }
 
-    function test_register_post_type() {
+    public function test_register_post_type() {
         $this->assertNull( get_post_type_object( 'foo' ) );
         register_post_type( 'foo' );
@@ -43 +43 @@
      * @ticket 48558
      */
-    function test_register_post_type_return_value() {
+    public function test_register_post_type_return_value() {
         $this->assertInstanceOf( 'WP_Post_Type', register_post_type( 'foo' ) );
     }
@@ -52 +52 @@
      * @expectedIncorrectUsage register_post_type
      */
-    function test_register_post_type_with_too_long_name() {
+    public function test_register_post_type_with_too_long_name() {
         // Post type too long.
         $this->assertInstanceOf( 'WP_Error', register_post_type( 'abcdefghijklmnopqrstuvwxyz0123456789' ) );
@@ -62 +62 @@
      * @expectedIncorrectUsage register_post_type
      */
-    function test_register_post_type_with_empty_name() {
+    public function test_register_post_type_with_empty_name() {
         // Post type too short.
         $this->assertInstanceOf( 'WP_Error', register_post_type( '' ) );
@@ -71 +71 @@
      * @covers ::register_post_type
      */
-    function test_register_post_type_exclude_from_search_should_default_to_opposite_value_of_public() {
+    public function test_register_post_type_exclude_from_search_should_default_to_opposite_value_of_public() {
         /*
          * 'public'              Default is false
@@ -85 +85 @@
      * @covers ::register_post_type
      */
-    function test_register_post_type_publicly_queryable_should_default_to_value_of_public() {
+    public function test_register_post_type_publicly_queryable_should_default_to_value_of_public() {
         /*
          * 'public'             Default is false
@@ -99 +99 @@
      * @covers ::register_post_type
      */
-    function test_register_post_type_show_ui_should_default_to_value_of_public() {
+    public function test_register_post_type_show_ui_should_default_to_value_of_public() {
         /*
          * 'public'  Default is false
@@ -113 +113 @@
      * @covers ::register_post_type
      */
-    function test_register_post_type_show_in_menu_should_default_to_value_of_show_ui() {
+    public function test_register_post_type_show_in_menu_should_default_to_value_of_show_ui() {
         /*
          * 'public'      Default is false
@@ -132 +132 @@
      * @covers ::register_post_type
      */
-    function test_register_post_type_show_in_nav_menus_should_default_to_value_of_public() {
+    public function test_register_post_type_show_in_nav_menus_should_default_to_value_of_public() {
         /*
          * 'public'            Default is false
@@ -146 +146 @@
      * @covers ::register_post_type
      */
-    function test_register_post_type_show_in_admin_bar_should_default_to_value_of_show_in_menu() {
+    public function test_register_post_type_show_in_admin_bar_should_default_to_value_of_show_in_menu() {
         /*
          * 'public'            Default is false
@@ -164 +164 @@
     }
 
-    function test_register_taxonomy_for_object_type() {
+    public function test_register_taxonomy_for_object_type() {
         global $wp_taxonomies;
 
@@ -186 +186 @@
     }
 
-    function test_post_type_exists() {
+    public function test_post_type_exists() {
         $this->assertFalse( post_type_exists( 'notaposttype' ) );
         $this->assertTrue( post_type_exists( 'post' ) );
     }
 
-    function test_post_type_supports() {
+    public function test_post_type_supports() {
         $this->assertTrue( post_type_supports( 'post', 'post-formats' ) );
         $this->assertFalse( post_type_supports( 'page', 'post-formats' ) );
@@ -202 +202 @@
      * @ticket 21586
      */
-    function test_post_type_with_no_support() {
+    public function test_post_type_with_no_support() {
         register_post_type( 'foo', array( 'supports' => array() ) );
         $this->assertTrue( post_type_supports( 'foo', 'editor' ) );
@@ -217 +217 @@
      * @ticket 23302
      */
-    function test_post_type_with_no_feed() {
+    public function test_post_type_with_no_feed() {
         global $wp_rewrite;
         $old_permastruct = get_option( 'permalink_structure' );