Changeset 52010 for trunk/tests/phpunit/tests/post/wpInsertPost.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/post/wpInsertPost.php (modified) (14 diffs)

trunk/tests/phpunit/tests/post/wpInsertPost.php

@@ -30 +30 @@
     }
 
-    static function tear_down_after_class() {
+    public static function tear_down_after_class() {
         $role = get_role( 'administrator' );
         $role->remove_cap( 'publish_mapped_meta_caps' );
@@ -38 +38 @@
     }
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -69 +69 @@
      * @ticket 11863
      */
-    function test_trashing_a_post_should_add_trashed_suffix_to_post_name() {
+    public function test_trashing_a_post_should_add_trashed_suffix_to_post_name() {
         $trashed_about_page_id = self::factory()->post->create(
             array(
@@ -100 +100 @@
      * @ticket 11863
      */
-    function test_trashed_posts_original_post_name_should_be_reassigned_after_untrashing() {
+    public function test_trashed_posts_original_post_name_should_be_reassigned_after_untrashing() {
         $about_page_id = self::factory()->post->create(
             array(
@@ -117 +117 @@
      * @ticket 11863
      */
-    function test_creating_a_new_post_should_add_trashed_suffix_to_post_name_of_trashed_posts_with_the_desired_slug() {
+    public function test_creating_a_new_post_should_add_trashed_suffix_to_post_name_of_trashed_posts_with_the_desired_slug() {
         $trashed_about_page_id = self::factory()->post->create(
             array(
@@ -141 +141 @@
      * @ticket 11863
      */
-    function test_untrashing_a_post_with_a_stored_desired_post_name_should_get_its_post_name_suffixed_if_another_post_has_taken_the_desired_post_name() {
+    public function test_untrashing_a_post_with_a_stored_desired_post_name_should_get_its_post_name_suffixed_if_another_post_has_taken_the_desired_post_name() {
         $about_page_id = self::factory()->post->create(
             array(
@@ -175 +175 @@
      * @dataProvider data_various_post_statuses
      */
-    function test_untrashing_a_post_should_always_restore_it_to_draft_status( $post_status ) {
+    public function test_untrashing_a_post_should_always_restore_it_to_draft_status( $post_status ) {
         $page_id = self::factory()->post->create(
             array(
@@ -193 +193 @@
      * @dataProvider data_various_post_statuses
      */
-    function test_wp_untrash_post_status_filter_restores_post_to_correct_status( $post_status ) {
+    public function test_wp_untrash_post_status_filter_restores_post_to_correct_status( $post_status ) {
         add_filter( 'wp_untrash_post_status', 'wp_untrash_post_set_previous_status', 10, 3 );
 
@@ -216 +216 @@
      * @return array Array of test arguments.
      */
-    function data_various_post_types() {
+    public function data_various_post_types() {
         return array(
             array(
@@ -235 +235 @@
      * @return array Array of test arguments.
      */
-    function data_various_post_statuses() {
+    public function data_various_post_statuses() {
         return array(
             array(
@@ -258 +258 @@
      * @dataProvider data_various_post_types
      */
-    function test_contributor_cannot_set_post_slug( $post_type ) {
+    public function test_contributor_cannot_set_post_slug( $post_type ) {
         wp_set_current_user( self::$user_ids['contributor'] );
 
@@ -297 +297 @@
      * @dataProvider data_various_post_types
      */
-    function test_administrator_can_set_post_slug( $post_type ) {
+    public function test_administrator_can_set_post_slug( $post_type ) {
         wp_set_current_user( self::$user_ids['administrator'] );
 
@@ -338 +338 @@
      * @ticket 42464
      */
-    function test_administrator_cannot_set_post_slug_on_post_type_they_cannot_publish() {
+    public function test_administrator_cannot_set_post_slug_on_post_type_they_cannot_publish() {
         wp_set_current_user( self::$user_ids['administrator'] );
 
@@ -374 +374 @@
      * @ticket 25347
      */
-    function test_scheduled_post_with_a_past_date_should_be_published() {
+    public function test_scheduled_post_with_a_past_date_should_be_published() {
 
         $now = new DateTimeImmutable( 'now', new DateTimeZone( 'UTC' ) );