Changeset 52010 for trunk/tests/phpunit/tests/query.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/query.php (modified) (7 diffs)

trunk/tests/phpunit/tests/query.php

@@ -3 +3 @@
 class Tests_Query extends WP_UnitTestCase {
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -13 +13 @@
      * @ticket 24785
      */
-    function test_nested_loop_reset_postdata() {
+    public function test_nested_loop_reset_postdata() {
         $post_id        = self::factory()->post->create();
         $nested_post_id = self::factory()->post->create();
@@ -33 +33 @@
      * @ticket 16471
      */
-    function test_default_query_var() {
+    public function test_default_query_var() {
         $query = new WP_Query;
         $this->assertSame( '', $query->get( 'nonexistent' ) );
@@ -43 +43 @@
      * @ticket 25380
      */
-    function test_pre_posts_per_page() {
+    public function test_pre_posts_per_page() {
         self::factory()->post->create_many( 10 );
 
@@ -53 +53 @@
     }
 
-    function filter_posts_per_page( &$query ) {
+    public function filter_posts_per_page( &$query ) {
         $query->set( 'posts_per_rss', 30 );
     }
@@ -60 +60 @@
      * @ticket 26627
      */
-    function test_tag_queried_object() {
+    public function test_tag_queried_object() {
         $slug = 'tag-slug-26627';
         self::factory()->tag->create( array( 'slug' => $slug ) );
         $tag = get_term_by( 'slug', $slug, 'post_tag' );
 
-        add_action( 'pre_get_posts', array( $this, '_tag_queried_object' ), 11 );
+        add_action( 'pre_get_posts', array( $this, 'tag_queried_object' ), 11 );
 
         $this->go_to( get_term_link( $tag ) );
@@ -76 +76 @@
         $this->assertEquals( get_queried_object(), $tag );
 
-        remove_action( 'pre_get_posts', array( $this, '_tag_queried_object' ), 11 );
-    }
-
-    function _tag_queried_object( &$query ) {
+        remove_action( 'pre_get_posts', array( $this, 'tag_queried_object' ), 11 );
+    }
+
+    public function tag_queried_object( &$query ) {
         $tag = get_term_by( 'slug', 'tag-slug-26627', 'post_tag' );
         $this->assertTrue( $query->is_tag() );