Changeset 52010 for trunk/tests/phpunit/tests/query/search.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/query/search.php (modified) (10 diffs)

trunk/tests/phpunit/tests/query/search.php

@@ -8 +8 @@
     protected $post_type;
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -17 +17 @@
     }
 
-    function tear_down() {
+    public function tear_down() {
         unset( $this->q );
 
@@ -23 +23 @@
     }
 
-    function get_search_results( $terms ) {
+    private function get_search_results( $terms ) {
         $args = http_build_query(
             array(
@@ -33 +33 @@
     }
 
-    function test_search_order_title_relevance() {
+    public function test_search_order_title_relevance() {
         foreach ( range( 1, 7 ) as $i ) {
             self::factory()->post->create(
@@ -53 +53 @@
     }
 
-    function test_search_terms_query_var() {
+    public function test_search_terms_query_var() {
         $terms = 'This is a search term';
         $query = new WP_Query( array( 's' => 'This is a search term' ) );
@@ -60 +60 @@
     }
 
-    function test_filter_stopwords() {
+    public function test_filter_stopwords() {
         $terms = 'This is a search term';
         add_filter( 'wp_search_stopwords', array( $this, 'filter_wp_search_stopwords' ) );
@@ -70 +70 @@
     }
 
-    function filter_wp_search_stopwords() {
+    public function filter_wp_search_stopwords() {
         return array();
     }
@@ -77 +77 @@
      * @ticket 38099
      */
-    function test_disable_search_exclusion_prefix() {
+    public function test_disable_search_exclusion_prefix() {
         $title = '-HYPHENATION_TEST';
 
@@ -102 +102 @@
      * @ticket 38099
      */
-    function test_change_search_exclusion_prefix() {
+    public function test_change_search_exclusion_prefix() {
         $title = '#OCTOTHORPE_TEST';
 
@@ -125 +125 @@
     }
 
-    function filter_search_exclusion_prefix_octothorpe() {
+    public function filter_search_exclusion_prefix_octothorpe() {
         return '#';
     }