Changeset 52010 for trunk/tests/phpunit/tests/rewrite.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/rewrite.php (modified) (22 diffs)

trunk/tests/phpunit/tests/rewrite.php

@@ -9 +9 @@
     private $home_url;
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
 
@@ -18 +18 @@
     }
 
-    function tear_down() {
+    public function tear_down() {
         global $wp_rewrite;
         $wp_rewrite->init();
@@ -86 +86 @@
     }
 
-    function test_url_to_postid() {
+    public function test_url_to_postid() {
 
         $id = self::factory()->post->create();
@@ -95 +95 @@
     }
 
-    function test_url_to_postid_set_url_scheme_https_to_http() {
+    public function test_url_to_postid_set_url_scheme_https_to_http() {
         $post_id   = self::factory()->post->create();
         $permalink = get_permalink( $post_id );
@@ -105 +105 @@
     }
 
-    function test_url_to_postid_set_url_scheme_http_to_https() {
+    public function test_url_to_postid_set_url_scheme_http_to_https() {
         $_SERVER['HTTPS'] = 'on';
 
@@ -125 +125 @@
      * @group ms-required
      */
-    function test_url_to_postid_of_http_site_when_current_site_uses_https() {
+    public function test_url_to_postid_of_http_site_when_current_site_uses_https() {
         $_SERVER['HTTPS'] = 'on';
 
@@ -131 +131 @@
         $this->blog_id_35531 = self::factory()->blog->create();
 
-        add_filter( 'home_url', array( $this, '_filter_http_home_url' ), 10, 4 );
+        add_filter( 'home_url', array( $this, 'filter_http_home_url' ), 10, 4 );
 
         switch_to_blog( $this->blog_id_35531 );
@@ -142 +142 @@
 
         // Cleanup.
-        remove_filter( 'home_url', array( $this, '_filter_http_home_url' ), 10 );
+        remove_filter( 'home_url', array( $this, 'filter_http_home_url' ), 10 );
 
         // Test the tests.
@@ -161 +161 @@
      * @return string                  The complete home URL including scheme and path.
      */
-    function _filter_http_home_url( $url, $path, $orig_scheme, $_blog_id ) {
+    public function filter_http_home_url( $url, $path, $orig_scheme, $_blog_id ) {
         global $blog_id;
 
@@ -171 +171 @@
     }
 
-    function test_url_to_postid_custom_post_type() {
+    public function test_url_to_postid_custom_post_type() {
         delete_option( 'rewrite_rules' );
 
@@ -183 +183 @@
     }
 
-    function test_url_to_postid_hierarchical() {
+    public function test_url_to_postid_hierarchical() {
 
         $parent_id = self::factory()->post->create(
@@ -203 +203 @@
     }
 
-    function test_url_to_postid_hierarchical_with_matching_leaves() {
+    public function test_url_to_postid_hierarchical_with_matching_leaves() {
 
         $parent_id       = self::factory()->post->create(
@@ -246 +246 @@
     }
 
-    function test_url_to_postid_home_has_path() {
+    public function test_url_to_postid_home_has_path() {
 
         update_option( 'home', home_url( '/example/' ) );
@@ -272 +272 @@
      * @ticket 30438
      */
-    function test_parse_request_home_path() {
+    public function test_parse_request_home_path() {
         $home_url = home_url( '/path/' );
         update_option( 'home', $home_url );
@@ -292 +292 @@
      * @ticket 30438
      */
-    function test_parse_request_home_path_with_regex_character() {
+    public function test_parse_request_home_path_with_regex_character() {
         $home_url       = home_url( '/ma.ch/' );
         $not_a_home_url = home_url( '/match/' );
@@ -329 +329 @@
      * @ticket 30018
      */
-    function test_parse_request_home_path_non_public_type() {
+    public function test_parse_request_home_path_non_public_type() {
         register_post_type( 'foo', array( 'public' => false ) );
 
@@ -341 +341 @@
     }
 
-    function test_url_to_postid_dupe_path() {
+    public function test_url_to_postid_dupe_path() {
         update_option( 'home', home_url( '/example/' ) );
 
@@ -361 +361 @@
      * Reveals bug introduced in WP 3.0
      */
-    function test_url_to_postid_home_url_collision() {
+    public function test_url_to_postid_home_url_collision() {
         update_option( 'home', home_url( '/example' ) );
 
@@ -382 +382 @@
      * @group ms-required
      */
-    function test_url_to_postid_ms_home_url_collision() {
+    public function test_url_to_postid_ms_home_url_collision() {
         $blog_id = self::factory()->blog->create( array( 'path' => '/example' ) );
         switch_to_blog( $blog_id );
@@ -403 +403 @@
      * @ticket 21970
      */
-    function test_url_to_postid_with_post_slug_that_clashes_with_a_trashed_page() {
+    public function test_url_to_postid_with_post_slug_that_clashes_with_a_trashed_page() {
         $this->set_permalink_structure( '/%postname%/' );
 
@@ -420 +420 @@
      * @ticket 34971
      */
-    function test_url_to_postid_static_front_page() {
+    public function test_url_to_postid_static_front_page() {
         $post_id = self::factory()->post->create( array( 'post_type' => 'page' ) );
 
@@ -454 +454 @@
      * @ticket 21970
      */
-    function test_parse_request_with_post_slug_that_clashes_with_a_trashed_page() {
+    public function test_parse_request_with_post_slug_that_clashes_with_a_trashed_page() {
         $this->set_permalink_structure( '/%postname%/' );