Changeset 52010 for trunk/tests/phpunit/tests/term/getTermBy.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/term/getTermBy.php (modified) (8 diffs)

trunk/tests/phpunit/tests/term/getTermBy.php

@@ -6 +6 @@
 class Tests_Term_GetTermBy extends WP_UnitTestCase {
 
-    function test_get_term_by_slug() {
+    public function test_get_term_by_slug() {
         $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
         $term2 = get_term_by( 'slug', 'foo', 'category' );
@@ -12 +12 @@
     }
 
-    function test_get_term_by_name() {
+    public function test_get_term_by_name() {
         $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
         $term2 = get_term_by( 'name', 'Foo', 'category' );
@@ -18 +18 @@
     }
 
-    function test_get_term_by_id() {
+    public function test_get_term_by_id() {
         $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
         $term2 = get_term_by( 'id', $term1['term_id'], 'category' );
@@ -27 +27 @@
      * 'term_id' is an alias of 'id'.
      */
-    function test_get_term_by_term_id() {
+    public function test_get_term_by_term_id() {
         $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
         $term2 = get_term_by( 'term_id', $term1['term_id'], 'category' );
@@ -36 +36 @@
      * @ticket 45163
      */
-    function test_get_term_by_uppercase_id() {
+    public function test_get_term_by_uppercase_id() {
         $term1 = wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
         $term2 = get_term_by( 'ID', $term1['term_id'], 'category' );
@@ -45 +45 @@
      * @ticket 21651
      */
-    function test_get_term_by_tt_id() {
+    public function test_get_term_by_tt_id() {
         $term1 = wp_insert_term( 'Foo', 'category' );
         $term2 = get_term_by( 'term_taxonomy_id', $term1['term_taxonomy_id'], 'category' );
@@ -51 +51 @@
     }
 
-    function test_get_term_by_unknown() {
+    public function test_get_term_by_unknown() {
         wp_insert_term( 'Foo', 'category', array( 'slug' => 'foo' ) );
         $term2 = get_term_by( 'unknown', 'foo', 'category' );
@@ -60 +60 @@
      * @ticket 33281
      */
-    function test_get_term_by_with_nonexistent_id_should_return_false() {
+    public function test_get_term_by_with_nonexistent_id_should_return_false() {
         $term = get_term_by( 'id', 123456, 'category' );
         $this->assertFalse( $term );