Changeset 52010 for trunk/tests/phpunit/tests/term/termCounts.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/term/termCounts.php (modified) (13 diffs)

trunk/tests/phpunit/tests/term/termCounts.php

@@ -105 +105 @@
      * }
      */
-    function data_term_count_changes_for_post_statuses() {
+    public function data_term_count_changes_for_post_statuses() {
         return array(
             // 0. Published post
@@ -147 +147 @@
      * }
      */
-    function data_term_counts_incremented_on_publish() {
+    public function data_term_counts_incremented_on_publish() {
         return array(
             // 0. Published post
@@ -170 +170 @@
      * @param int    $change               Expected change upon publish.
      */
-    function test_term_count_transitions_update_term_counts( $original_post_status, $new_post_status, $change ) {
+    public function test_term_count_transitions_update_term_counts( $original_post_status, $new_post_status, $change ) {
         $post_id    = self::$post_ids[ $original_post_status ];
         $term_count = get_term( get_option( 'default_category' ) )->count;
@@ -194 +194 @@
      * }
      */
-    function data_term_count_transitions_update_term_counts() {
+    public function data_term_count_transitions_update_term_counts() {
         return array(
             // 0. Draft -> published post
@@ -225 +225 @@
     }
 
-    function add_custom_status_to_counted_statuses( $statuses ) {
+    public function add_custom_status_to_counted_statuses( $statuses ) {
         array_push( $statuses, 'custom' );
         return $statuses;
@@ -270 +270 @@
      * }
      */
-    function data_term_count_changes_for_update_post_term_count_statuses_filter() {
+    public function data_term_count_changes_for_update_post_term_count_statuses_filter() {
         return array(
             // 0. Published post
@@ -320 +320 @@
      * }
      */
-    function data_term_count_changes_for_post_statuses_with_attachments() {
+    public function data_term_count_changes_for_post_statuses_with_attachments() {
         return array(
             // 0. Published post
@@ -371 +371 @@
      * }
      */
-    function data_term_counts_incremented_on_publish_with_attachments() {
+    public function data_term_counts_incremented_on_publish_with_attachments() {
         return array(
             // 0. Published post
@@ -394 +394 @@
      * @param int    $change               Expected change upon publish.
      */
-    function test_term_count_transitions_update_term_counts_with_attachments( $original_post_status, $new_post_status, $change ) {
+    public function test_term_count_transitions_update_term_counts_with_attachments( $original_post_status, $new_post_status, $change ) {
         $post_id = self::$post_ids[ $original_post_status ];
         wp_add_object_terms( $post_id, self::$attachment_term, 'wp_test_tax_counts' );
@@ -427 +427 @@
      * }
      */
-    function data_term_count_transitions_update_term_counts_with_attachments() {
+    public function data_term_count_transitions_update_term_counts_with_attachments() {
         return array(
             // 0. Draft -> published post
@@ -495 +495 @@
      * }
      */
-    function data_term_counts_incremented_on_publish_with_untermed_attachments() {
+    public function data_term_counts_incremented_on_publish_with_untermed_attachments() {
         return array(
             // 0. Published post
@@ -518 +518 @@
      * @param int    $change               Expected change upon publish.
      */
-    function test_term_count_transitions_update_term_counts_with_untermed_attachments( $original_post_status, $new_post_status, $change ) {
+    public function test_term_count_transitions_update_term_counts_with_untermed_attachments( $original_post_status, $new_post_status, $change ) {
         $post_id = self::$post_ids[ $original_post_status ];
         wp_add_object_terms( $post_id, self::$attachment_term, 'wp_test_tax_counts' );
@@ -550 +550 @@
      * }
      */
-    function data_term_count_transitions_update_term_counts_with_untermed_attachments() {
+    public function data_term_count_transitions_update_term_counts_with_untermed_attachments() {
         return array(
             // 0. Draft -> published post