Changeset 52010 for trunk/tests/phpunit/tests/theme.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/theme.php (modified) (18 diffs)

trunk/tests/phpunit/tests/theme.php

@@ -23 +23 @@
     );
 
-    function set_up() {
+    public function set_up() {
         global $wp_theme_directories;
 
@@ -31 +31 @@
         $wp_theme_directories        = array( WP_CONTENT_DIR . '/themes' );
 
-        add_filter( 'extra_theme_headers', array( $this, '_theme_data_extra_headers' ) );
+        add_filter( 'extra_theme_headers', array( $this, 'theme_data_extra_headers' ) );
         wp_clean_themes_cache();
         unset( $GLOBALS['wp_themes'] );
     }
 
-    function tear_down() {
+    public function tear_down() {
         global $wp_theme_directories;
 
         $wp_theme_directories = $this->wp_theme_directories;
 
-        remove_filter( 'extra_theme_headers', array( $this, '_theme_data_extra_headers' ) );
+        remove_filter( 'extra_theme_headers', array( $this, 'theme_data_extra_headers' ) );
         wp_clean_themes_cache();
         unset( $GLOBALS['wp_themes'] );
@@ -48 +48 @@
     }
 
-    function test_wp_get_themes_default() {
+    public function test_wp_get_themes_default() {
         $themes = wp_get_themes();
         $this->assertInstanceOf( 'WP_Theme', $themes[ $this->theme_slug ] );
@@ -62 +62 @@
      * @expectedDeprecated get_themes
      */
-    function test_get_themes_default() {
+    public function test_get_themes_default() {
         $themes = get_themes();
         $this->assertInstanceOf( 'WP_Theme', $themes[ $this->theme_name ] );
@@ -76 +76 @@
      * @expectedDeprecated get_themes
      */
-    function test_get_theme() {
+    public function test_get_theme() {
         $themes = get_themes();
         foreach ( array_keys( $themes ) as $name ) {
@@ -87 +87 @@
     }
 
-    function test_wp_get_theme() {
+    public function test_wp_get_theme() {
         $themes = wp_get_themes();
         foreach ( $themes as $theme ) {
@@ -102 +102 @@
      * @expectedDeprecated get_themes
      */
-    function test_get_themes_contents() {
+    public function test_get_themes_contents() {
         $themes = get_themes();
         // Generic tests that should hold true for any theme.
@@ -168 +168 @@
     }
 
-    function test_wp_get_theme_contents() {
+    public function test_wp_get_theme_contents() {
         $theme = wp_get_theme( $this->theme_slug );
 
@@ -193 +193 @@
      * @ticket 29925
      */
-    function test_default_theme_in_default_theme_list() {
+    public function test_default_theme_in_default_theme_list() {
         $latest_default_theme = WP_Theme::get_core_default_theme();
         if ( ! $latest_default_theme->exists() || 'twenty' !== substr( $latest_default_theme->get_stylesheet(), 0, 6 ) ) {
@@ -201 +201 @@
     }
 
-    function test_default_themes_have_textdomain() {
+    public function test_default_themes_have_textdomain() {
         foreach ( $this->default_themes as $theme ) {
             if ( wp_get_theme( $theme )->exists() ) {
@@ -212 +212 @@
      * @ticket 48566
      */
-    function test_year_in_readme() {
+    public function test_year_in_readme() {
         // This test is designed to only run on trunk/master.
         $this->skipOnAutomatedBranches();
@@ -240 +240 @@
      * @expectedDeprecated get_theme_data
      */
-    function test_extra_theme_headers() {
+    public function test_extra_theme_headers() {
         $wp_theme = wp_get_theme( $this->theme_slug );
         $this->assertNotEmpty( $wp_theme->get( 'License' ) );
@@ -252 +252 @@
     }
 
-    function _theme_data_extra_headers() {
+    public function theme_data_extra_headers() {
         return array( 'License' );
     }
@@ -260 +260 @@
      * @expectedDeprecated get_current_theme
      */
-    function test_switch_theme() {
+    public function test_switch_theme() {
         $themes = get_themes();
 
@@ -331 +331 @@
     }
 
-    function test_switch_theme_bogus() {
+    public function test_switch_theme_bogus() {
         // Try switching to a theme that doesn't exist.
         $template = rand_str();
@@ -353 +353 @@
      * @covers ::_wp_keep_alive_customize_changeset_dependent_auto_drafts
      */
-    function test_wp_keep_alive_customize_changeset_dependent_auto_drafts() {
+    public function test_wp_keep_alive_customize_changeset_dependent_auto_drafts() {
         $nav_created_post_ids = $this->factory()->post->create_many(
             2,
@@ -622 +622 @@
      * @ticket 49406
      *
-     * @dataProvider _dp_register_theme_support_validation
+     * @dataProvider data_register_theme_support_validation
      *
      * @param string $error_code The error code expected.
@@ -634 +634 @@
     }
 
-    public function _dp_register_theme_support_validation() {
+    public function data_register_theme_support_validation() {
         return array(
             array(