Changeset 52010 for trunk/tests/phpunit/tests/theme/support.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/theme/support.php (modified) (9 diffs)

trunk/tests/phpunit/tests/theme/support.php

@@ -6 +6 @@
 class Tests_Theme_Support extends WP_UnitTestCase {
 
-    function test_the_basics() {
+    public function test_the_basics() {
         add_theme_support( 'automatic-feed-links' );
         $this->assertTrue( current_theme_supports( 'automatic-feed-links' ) );
@@ -15 +15 @@
     }
 
-    function test_admin_bar() {
+    public function test_admin_bar() {
         add_theme_support( 'admin-bar' );
         $this->assertTrue( current_theme_supports( 'admin-bar' ) );
@@ -78 +78 @@
      * @ticket 24932
      */
-    function test_supports_html5() {
+    public function test_supports_html5() {
         remove_theme_support( 'html5' );
         $this->assertFalse( current_theme_supports( 'html5' ) );
@@ -95 +95 @@
      * @expectedIncorrectUsage add_theme_support( 'html5' )
      */
-    function test_supports_html5_subset() {
+    public function test_supports_html5_subset() {
         remove_theme_support( 'html5' );
         $this->assertFalse( current_theme_supports( 'html5' ) );
@@ -126 +126 @@
      * @expectedIncorrectUsage add_theme_support( 'html5' )
      */
-    function test_supports_html5_invalid() {
+    public function test_supports_html5_invalid() {
         remove_theme_support( 'html5' );
         $this->assertFalse( add_theme_support( 'html5', 'comment-form' ) );
@@ -138 +138 @@
      * @expectedIncorrectUsage add_theme_support( 'post-formats' )
      */
-    function test_supports_post_formats_doing_it_wrong() {
+    public function test_supports_post_formats_doing_it_wrong() {
         // The second parameter should be an array.
         $this->assertFalse( add_theme_support( 'post-formats' ) );
     }
 
-    function supports_foobar( $yesno, $args, $feature ) {
+    public function supports_foobar( $yesno, $args, $feature ) {
         if ( $args[0] === $feature[0] ) {
             return true;
@@ -150 +150 @@
     }
 
-    function test_plugin_hook() {
+    public function test_plugin_hook() {
         $this->assertFalse( current_theme_supports( 'foobar' ) );
         add_theme_support( 'foobar' );
@@ -168 +168 @@
      * @ticket 26900
      */
-    function test_supports_menus() {
+    public function test_supports_menus() {
         // Start fresh.
         foreach ( get_registered_nav_menus() as $location => $desc ) {
@@ -198 +198 @@
      * @ticket 45125
      */
-    function test_responsive_embeds() {
+    public function test_responsive_embeds() {
         add_theme_support( 'responsive-embeds' );
         $this->assertTrue( current_theme_supports( 'responsive-embeds' ) );