Changeset 52010 for trunk/tests/phpunit/tests/theme/themeDir.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/theme/themeDir.php (modified) (14 diffs)

trunk/tests/phpunit/tests/theme/themeDir.php

@@ -8 +8 @@
 class Tests_Theme_ThemeDir extends WP_UnitTestCase {
 
-    function set_up() {
+    public function set_up() {
         parent::set_up();
         $this->theme_root = DIR_TESTDATA . '/themedir1';
@@ -17 +17 @@
         $GLOBALS['wp_theme_directories'] = array( WP_CONTENT_DIR . '/themes', $this->theme_root );
 
-        add_filter( 'theme_root', array( $this, '_theme_root' ) );
-        add_filter( 'stylesheet_root', array( $this, '_theme_root' ) );
-        add_filter( 'template_root', array( $this, '_theme_root' ) );
+        add_filter( 'theme_root', array( $this, 'filter_theme_root' ) );
+        add_filter( 'stylesheet_root', array( $this, 'filter_theme_root' ) );
+        add_filter( 'template_root', array( $this, 'filter_theme_root' ) );
         // Clear caches.
         wp_clean_themes_cache();
@@ -25 +25 @@
     }
 
-    function tear_down() {
+    public function tear_down() {
         $GLOBALS['wp_theme_directories'] = $this->orig_theme_dir;
         wp_clean_themes_cache();
@@ -33 +33 @@
 
     // Replace the normal theme root directory with our premade test directory.
-    function _theme_root( $dir ) {
+    public function filter_theme_root( $dir ) {
         return $this->theme_root;
     }
@@ -41 +41 @@
      * @expectedDeprecated get_themes
      */
-    function test_theme_default() {
+    public function test_theme_default() {
         $themes = get_themes();
         $theme  = get_theme( 'WordPress Default' );
@@ -72 +72 @@
      * @expectedDeprecated get_themes
      */
-    function test_theme_sandbox() {
+    public function test_theme_sandbox() {
         $theme = get_theme( 'Sandbox' );
 
@@ -108 +108 @@
      * @expectedDeprecated get_themes
      */
-    function test_theme_stylesheet_only() {
+    public function test_theme_stylesheet_only() {
         $themes = get_themes();
 
@@ -138 +138 @@
      * @expectedDeprecated get_themes
      */
-    function test_theme_list() {
+    public function test_theme_list() {
         $themes = get_themes();
 
@@ -175 +175 @@
      * @expectedDeprecated get_broken_themes
      */
-    function test_broken_themes() {
+    public function test_broken_themes() {
         $themes = get_themes();
 
@@ -194 +194 @@
     }
 
-    function test_wp_get_theme_with_non_default_theme_root() {
+    public function test_wp_get_theme_with_non_default_theme_root() {
         $this->assertFalse( wp_get_theme( 'sandbox', $this->theme_root )->errors() );
         $this->assertFalse( wp_get_theme( 'sandbox' )->errors() );
@@ -202 +202 @@
      * @expectedDeprecated get_themes
      */
-    function test_page_templates() {
+    public function test_page_templates() {
         $themes = get_themes();
 
@@ -215 +215 @@
      * @expectedDeprecated get_theme_data
      */
-    function test_get_theme_data_top_level() {
+    public function test_get_theme_data_top_level() {
         $theme_data = get_theme_data( DIR_TESTDATA . '/themedir1/theme1/style.css' );
 
@@ -234 +234 @@
      * @expectedDeprecated get_theme_data
      */
-    function test_get_theme_data_subdir() {
+    public function test_get_theme_data_subdir() {
         $theme_data = get_theme_data( $this->theme_root . '/subdir/theme2/style.css' );
 
@@ -253 +253 @@
      * @ticket 28662
      */
-    function test_theme_dir_slashes() {
+    public function test_theme_dir_slashes() {
         $size = count( $GLOBALS['wp_theme_directories'] );