Changeset 52010 for trunk/tests/phpunit/tests/user/listAuthors.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/user/listAuthors.php (modified) (13 diffs)

trunk/tests/phpunit/tests/user/listAuthors.php

@@ -75 +75 @@
         }
 
-        function test_wp_list_authors_default() {
+        public function test_wp_list_authors_default() {
                 $expected['default'] =
                         '<li><a href="' . self::$user_urls[1] . '" title="Posts by bob">bob</a></li>' .
@@ -84 +84 @@
         }
 
-        function test_wp_list_authors_orderby() {
+        public function test_wp_list_authors_orderby() {
                 $expected['post_count'] =
                         '<li><a href="' . self::$user_urls[0] . '" title="Posts by zack">zack</a></li>' .
@@ -101 +101 @@
         }
 
-        function test_wp_list_authors_order() {
+        public function test_wp_list_authors_order() {
                 $expected['id'] =
                         '<li><a href="' . self::$user_urls[2] . '" title="Posts by paul">paul</a></li>' .
@@ -119 +119 @@
         }
 
-        function test_wp_list_authors_optioncount() {
+        public function test_wp_list_authors_optioncount() {
                 $expected['optioncount'] =
                         '<li><a href="' . self::$user_urls[1] . '" title="Posts by bob">bob</a> (2)</li>' .
@@ -136 +136 @@
         }
 
-        function test_wp_list_authors_exclude_admin() {
+        public function test_wp_list_authors_exclude_admin() {
                 self::factory()->post->create(
                         array(
@@ -161 +161 @@
         }
 
-        function test_wp_list_authors_show_fullname() {
+        public function test_wp_list_authors_show_fullname() {
                 $expected['show_fullname'] =
                         '<li><a href="' . self::$user_urls[1] . '" title="Posts by bob">bob reno</a></li>' .
@@ -178 +178 @@
         }
 
-        function test_wp_list_authors_hide_empty() {
+        public function test_wp_list_authors_hide_empty() {
                 $fred_id = self::$fred_id;
 
@@ -198 +198 @@
         }
 
-        function test_wp_list_authors_echo() {
+        public function test_wp_list_authors_echo() {
                 $expected['echo'] =
                         '<li><a href="' . self::$user_urls[1] . '" title="Posts by bob">bob</a></li>' .
@@ -208 +208 @@
         }
 
-        function test_wp_list_authors_feed() {
+        public function test_wp_list_authors_feed() {
                 $url0 = get_author_feed_link( self::$user_ids[0] );
                 $url1 = get_author_feed_link( self::$user_ids[1] );
@@ -229 +229 @@
         }
 
-        function test_wp_list_authors_feed_image() {
+        public function test_wp_list_authors_feed_image() {
                 $url0 = get_author_feed_link( self::$user_ids[0] );
                 $url1 = get_author_feed_link( self::$user_ids[1] );
@@ -253 +253 @@
          * @ticket 26538
          */
-        function test_wp_list_authors_feed_type() {
+        public function test_wp_list_authors_feed_type() {
                 $url0 = get_author_feed_link( self::$user_ids[0], 'atom' );
                 $url1 = get_author_feed_link( self::$user_ids[1], 'atom' );
@@ -275 +275 @@
         }
 
-        function test_wp_list_authors_style() {
+        public function test_wp_list_authors_style() {
                 $expected['style'] =
                         '<a href="' . self::$user_urls[1] . '" title="Posts by bob">bob</a>, ' .
@@ -292 +292 @@
         }
 
-        function test_wp_list_authors_html() {
+        public function test_wp_list_authors_html() {
                 $expected['html'] = 'bob, paul, zack';