Changeset 52010 for trunk/tests/phpunit/tests/widgets/wpWidgetMedia.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/widgets/wpWidgetMedia.php (modified) (18 diffs)

trunk/tests/phpunit/tests/widgets/wpWidgetMedia.php

@@ -20 +20 @@
      * @global WP_Styles $wp_styles
      */
-    function clean_up_global_scope() {
+    public function clean_up_global_scope() {
         global $wp_scripts, $wp_styles;
         parent::clean_up_global_scope();
@@ -36 +36 @@
      * @return PHPUnit_Framework_MockObject_MockObject|WP_Widget_Media Mocked instance.
      */
-    function get_mocked_class_instance( $id_base = 'mocked', $name = 'Mocked', $widget_options = array(), $control_options = array() ) {
+    private function get_mocked_class_instance( $id_base = 'mocked', $name = 'Mocked', $widget_options = array(), $control_options = array() ) {
         $original_class_name       = 'WP_Widget_Media';
         $arguments                 = array( $id_base, $name, $widget_options, $control_options );
@@ -54 +54 @@
      * @covers WP_Widget_Media::_register
      */
-    function test_constructor() {
+    public function test_constructor() {
         $widget = $this->get_mocked_class_instance();
         $widget->_register();
@@ -114 +114 @@
      * @covers WP_Widget_Media::_register
      */
-    function test_constructor_in_customize_preview() {
+    public function test_constructor_in_customize_preview() {
         global $wp_customize;
         wp_set_current_user(
@@ -142 +142 @@
      * @requires function imagejpeg
      */
-    function test_is_attachment_with_mime_type() {
+    public function test_is_attachment_with_mime_type() {
 
         $test_image = get_temp_dir() . 'canola.jpg';
@@ -171 +171 @@
      * @covers WP_Widget_Media::sanitize_token_list
      */
-    function test_sanitize_token_list_string() {
+    public function test_sanitize_token_list_string() {
         $widget = $this->get_mocked_class_instance();
 
@@ -208 +208 @@
      * @covers WP_Widget_Media::get_instance_schema
      */
-    function test_get_instance_schema() {
+    public function test_get_instance_schema() {
         $widget = $this->get_mocked_class_instance();
         $schema = $widget->get_instance_schema();
@@ -236 +236 @@
      * @covers WP_Widget_Media::update
      */
-    function test_update() {
+    public function test_update() {
         $widget   = $this->get_mocked_class_instance();
         $instance = array();
@@ -297 +297 @@
         $this->assertSame( $result, $instance );
 
-        add_filter( 'sanitize_text_field', array( $this, '_return_wp_error' ) );
+        add_filter( 'sanitize_text_field', array( $this, 'return_wp_error' ) );
         $result = $widget->update(
             array(
@@ -304 +304 @@
             $instance
         );
-        remove_filter( 'sanitize_text_field', array( $this, '_return_wp_error' ) );
+        remove_filter( 'sanitize_text_field', array( $this, 'return_wp_error' ) );
         $this->assertSame( $result, $instance );
     }
@@ -313 +313 @@
      * @return \WP_Error
      */
-    function _return_wp_error() {
+    public function return_wp_error() {
         return new WP_Error( 'some-error', 'This is not valid!' );
     }
@@ -323 +323 @@
      * @covers WP_Widget_Media::render_media
      */
-    function test_widget() {
+    public function test_widget() {
         $args     = array(
             'before_title'  => '<h2>',
@@ -387 +387 @@
      * @return array Instance.
      */
-    function filter_widget_mocked_instance( $instance, $args, $object ) {
+    public function filter_widget_mocked_instance( $instance, $args, $object ) {
         $this->widget_instance_filter_args = func_get_args();
         return $instance;
@@ -397 +397 @@
      * @covers WP_Widget_Media::form
      */
-    function test_form() {
+    public function test_form() {
         $widget = $this->get_mocked_class_instance();
 
@@ -414 +414 @@
      * @covers WP_Widget_Media::display_media_state
      */
-    function test_display_media_state() {
+    public function test_display_media_state() {
         $widget        = $this->get_mocked_class_instance();
         $attachment_id = self::factory()->attachment->create_object(
@@ -456 +456 @@
      * @covers WP_Widget_Media::enqueue_admin_scripts
      */
-    function test_enqueue_admin_scripts() {
+    public function test_enqueue_admin_scripts() {
         set_current_screen( 'widgets.php' );
         $widget = $this->get_mocked_class_instance();
@@ -469 +469 @@
      * @covers WP_Widget_Media::render_control_template_scripts
      */
-    function test_render_control_template_scripts() {
+    public function test_render_control_template_scripts() {
         $widget = $this->get_mocked_class_instance();
 
@@ -484 +484 @@
      * @covers WP_Widget_Media::has_content
      */
-    function test_has_content() {
+    public function test_has_content() {
         $attachment_id = self::factory()->attachment->create_object(
             array(