Changeset 52010 for trunk/tests/phpunit/tests/xmlrpc/mw/newPost.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/xmlrpc/mw/newPost.php (modified) (15 diffs)

trunk/tests/phpunit/tests/xmlrpc/mw/newPost.php

@@ -6 +6 @@
 class Tests_XMLRPC_mw_newPost extends WP_XMLRPC_UnitTestCase {
 
-    function test_invalid_username_password() {
+    public function test_invalid_username_password() {
         $post   = array();
         $result = $this->myxmlrpcserver->mw_newPost( array( 1, 'username', 'password', $post ) );
@@ -13 +13 @@
     }
 
-    function test_incapable_user() {
+    public function test_incapable_user() {
         $this->make_user_by_role( 'subscriber' );
 
@@ -22 +22 @@
     }
 
-    function test_no_content() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_no_content() {
         $this->make_user_by_role( 'author' );
 
@@ -42 +32 @@
     }
 
-    function test_basic_content() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_basic_content() {
         $this->make_user_by_role( 'author' );
 
@@ -61 +41 @@
     }
 
-    function test_ignore_id() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_ignore_id() {
         $this->make_user_by_role( 'author' );
 
@@ -83 +53 @@
     }
 
-    function test_capable_publish() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_capable_publish() {
         $this->make_user_by_role( 'author' );
 
@@ -104 +64 @@
     }
 
-    function test_incapable_publish() {
+    public function test_incapable_publish() {
         $this->make_user_by_role( 'contributor' );
 
@@ -116 +76 @@
     }
 
-    function test_capable_other_author() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_capable_other_author() {
         $this->make_user_by_role( 'editor' );
         $other_author_id = $this->make_user_by_role( 'author' );
@@ -138 +88 @@
     }
 
-    function test_incapable_other_author() {
+    public function test_incapable_other_author() {
         $this->make_user_by_role( 'contributor' );
         $other_author_id = $this->make_user_by_role( 'author' );
@@ -154 +104 @@
      * @ticket 20356
      */
-    function test_invalid_author() {
+    public function test_invalid_author() {
         $this->make_user_by_role( 'editor' );
 
@@ -166 +116 @@
     }
 
-    function test_empty_author() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_empty_author() {
         $my_author_id = $this->make_user_by_role( 'author' );
 
@@ -192 +132 @@
      * @requires function imagejpeg
      */
-    function test_post_thumbnail() {
+    public function test_post_thumbnail() {
         add_theme_support( 'post-thumbnails' );
 
@@ -212 +152 @@
     }
 
-    function test_incapable_set_post_type_as_page() {
+    public function test_incapable_set_post_type_as_page() {
         $this->make_user_by_role( 'author' );
 
@@ -224 +164 @@
     }
 
-    function test_capable_set_post_type_as_page() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_capable_set_post_type_as_page() {
         $this->make_user_by_role( 'editor' );
 
@@ -254 +184 @@
      * @ticket 16985
      */
-    function test_draft_post_date() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_draft_post_date() {
         $this->make_user_by_role( 'editor' );