Changeset 52010 for trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php (modified) (19 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/editPost.php

@@ -6 +6 @@
 class Tests_XMLRPC_wp_editPost extends WP_XMLRPC_UnitTestCase {
 
-    function test_invalid_username_password() {
+    public function test_invalid_username_password() {
         $result = $this->myxmlrpcserver->wp_editPost( array( 1, 'username', 'password', 0, array() ) );
         $this->assertIXRError( $result );
@@ -12 +12 @@
     }
 
-    function test_edit_own_post() {
+    public function test_edit_own_post() {
         $contributor_id = $this->make_user_by_role( 'contributor' );
 
@@ -31 +31 @@
     }
 
-    function test_capable_edit_others_post() {
+    public function test_capable_edit_others_post() {
         $contributor_id = $this->make_user_by_role( 'contributor' );
         $this->make_user_by_role( 'editor' );
@@ -51 +51 @@
     }
 
-    function test_incapable_edit_others_post() {
+    public function test_incapable_edit_others_post() {
         $this->make_user_by_role( 'contributor' );
         $author_id = $this->make_user_by_role( 'author' );
@@ -72 +72 @@
     }
 
-    function test_capable_reassign_author() {
+    public function test_capable_reassign_author() {
         $contributor_id = $this->make_user_by_role( 'contributor' );
         $author_id      = $this->make_user_by_role( 'author' );
@@ -92 +92 @@
     }
 
-    function test_incapable_reassign_author() {
+    public function test_incapable_reassign_author() {
         $contributor_id = $this->make_user_by_role( 'contributor' );
         $author_id      = $this->make_user_by_role( 'author' );
@@ -114 +114 @@
      * @ticket 24916
      */
-    function test_capable_reassign_author_to_self() {
+    public function test_capable_reassign_author_to_self() {
         $contributor_id = $this->make_user_by_role( 'contributor' );
         $editor_id      = $this->make_user_by_role( 'editor' );
@@ -136 +136 @@
      * @requires function imagejpeg
      */
-    function test_post_thumbnail() {
+    public function test_post_thumbnail() {
         add_theme_support( 'post-thumbnails' );
 
@@ -196 +196 @@
     }
 
-    function test_edit_custom_fields() {
+    public function test_edit_custom_fields() {
         $contributor_id = $this->make_user_by_role( 'contributor' );
 
@@ -240 +240 @@
     }
 
-    function test_capable_unsticky() {
+    public function test_capable_unsticky() {
         $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -252 +252 @@
     }
 
-    function test_password_transition_unsticky() {
+    public function test_password_transition_unsticky() {
         // When transitioning to private status or adding a post password, post should be un-stuck.
         $editor_id = $this->make_user_by_role( 'editor' );
@@ -267 +267 @@
     }
 
-    function test_if_not_modified_since() {
+    public function test_if_not_modified_since() {
         $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -306 +306 @@
     }
 
-    function test_edit_attachment() {
+    public function test_edit_attachment() {
         $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -327 +327 @@
     }
 
-    function test_use_invalid_post_status() {
+    public function test_use_invalid_post_status() {
         $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -349 +349 @@
      * @ticket 22220
      */
-    function test_loss_of_categories_on_edit() {
+    public function test_loss_of_categories_on_edit() {
         $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -380 +380 @@
      * @ticket 26686
      */
-    function test_clear_categories_on_edit() {
+    public function test_clear_categories_on_edit() {
         $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -407 +407 @@
      * @ticket 23219
      */
-    function test_add_enclosure_if_new() {
+    public function test_add_enclosure_if_new() {
         // Sample enclosure data.
         $enclosure = array(
@@ -468 +468 @@
      * @ticket 35874
      */
-    function test_draft_not_prematurely_published() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_draft_not_prematurely_published() {
         $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -514 +504 @@
      * @ticket 45322
      */
-    function test_draft_not_assigned_published_date() {
-        if ( PHP_VERSION_ID >= 80100 ) {
-            /*
-             * For the time being, ignoring PHP 8.1 "null to non-nullable" deprecations coming in
-             * via hooked in filter functions until a more structural solution to the
-             * "missing input validation" conundrum has been architected and implemented.
-             */
-            $this->expectDeprecation();
-            $this->expectDeprecationMessageMatches( '`Passing null to parameter \#[0-9]+ \(\$[^\)]+\) of type [^ ]+ is deprecated`' );
-        }
-
+    public function test_draft_not_assigned_published_date() {
         $editor_id = $this->make_user_by_role( 'editor' );