Changeset 52010 for trunk/tests/phpunit/tests/xmlrpc/wp/getPages.php

Timestamp:

11/04/2021 03:22:47 PM (4 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getPages.php (modified) (5 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getPages.php

@@ -31 +31 @@
     }
 
-    function test_invalid_username_password() {
+    public function test_invalid_username_password() {
         $result = $this->myxmlrpcserver->wp_getPages( array( 1, 'username', 'password' ) );
         $this->assertIXRError( $result );
@@ -37 +37 @@
     }
 
-    function test_incapable_user() {
+    public function test_incapable_user() {
         $this->make_user_by_role( 'contributor' );
 
@@ -45 +45 @@
     }
 
-    function test_capable_user() {
+    public function test_capable_user() {
         $results = $this->myxmlrpcserver->wp_getPages( array( 1, 'administrator', 'administrator' ) );
         $this->assertNotIXRError( $results );
@@ -55 +55 @@
     }
 
-    function remove_editor_edit_page_cap( $caps, $cap, $user_id, $args ) {
+    public function remove_editor_edit_page_cap( $caps, $cap, $user_id, $args ) {
         if ( in_array( $cap, array( 'edit_page', 'edit_others_pages' ), true ) ) {
             if ( $user_id === self::$editor_id && $args[0] === self::$post_id ) {
@@ -68 +68 @@
      * @ticket 20629
      */
-    function test_semi_capable_user() {
+    public function test_semi_capable_user() {
         add_filter( 'map_meta_cap', array( $this, 'remove_editor_edit_page_cap' ), 10, 4 );