Changeset 52010 for trunk/tests/phpunit/tests/xmlrpc/wp/getUser.php

Timestamp:

11/04/2021 03:22:47 PM (5 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/getUser.php (modified) (9 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/getUser.php

@@ -8 +8 @@
         protected $administrator_id;
 
-        function set_up() {
+        public function set_up() {
                 parent::set_up();
 
@@ -18 +18 @@
         }
 
-        function test_invalid_username_password() {
+        public function test_invalid_username_password() {
                 $result = $this->myxmlrpcserver->wp_getUser( array( 1, 'username', 'password', 1 ) );
                 $this->assertIXRError( $result );
@@ -24 +24 @@
         }
 
-        function test_invalid_user() {
+        public function test_invalid_user() {
                 $result = $this->myxmlrpcserver->wp_getUser( array( 1, 'administrator', 'administrator', 34902348908234 ) );
                 $this->assertIXRError( $result );
@@ -30 +30 @@
         }
 
-        function test_incapable_user() {
+        public function test_incapable_user() {
                 $this->make_user_by_role( 'subscriber' );
                 $editor_id = $this->make_user_by_role( 'editor' );
@@ -39 +39 @@
         }
 
-        function test_subscriber_self() {
+        public function test_subscriber_self() {
                 $subscriber_id = $this->make_user_by_role( 'subscriber' );
 
@@ -47 +47 @@
         }
 
-        function test_valid_user() {
+        public function test_valid_user() {
                 $registered_date = strtotime( '-1 day' );
                 $user_data       = array(
@@ -102 +102 @@
         }
 
-        function test_no_fields() {
+        public function test_no_fields() {
                 $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -113 +113 @@
         }
 
-        function test_basic_fields() {
+        public function test_basic_fields() {
                 $editor_id = $this->make_user_by_role( 'editor' );
 
@@ -127 +127 @@
         }
 
-        function test_arbitrary_fields() {
+        public function test_arbitrary_fields() {
                 $editor_id = $this->make_user_by_role( 'editor' );