Changeset 52010 for trunk/tests/phpunit/tests/xmlrpc/wp/newTerm.php

Timestamp:

11/04/2021 03:22:47 PM (3 years ago)

Author:

hellofromTonya

Message:

Coding Standards: Add visibility to methods in tests/phpunit/tests/.

Adds a public visibility to test fixtures, tests, data providers, and callbacks methods.

Adds a private visibility to helper methods within test classes.

Renames callbacks and helpers that previously started with a _ prefix. Why? For consistency and to leverage using the method visibility. Further naming standardizations is beyond the scope of this commit.

Props costdev, jrf, hellofromTonya.
Fixes #54177.

File:

• trunk/tests/phpunit/tests/xmlrpc/wp/newTerm.php (modified) (10 diffs)

trunk/tests/phpunit/tests/xmlrpc/wp/newTerm.php

@@ -16 +16 @@
     }
 
-    function test_invalid_username_password() {
+    public function test_invalid_username_password() {
         $result = $this->myxmlrpcserver->wp_newTerm( array( 1, 'username', 'password', array() ) );
         $this->assertIXRError( $result );
@@ -22 +22 @@
     }
 
-    function test_empty_taxonomy() {
+    public function test_empty_taxonomy() {
         $this->make_user_by_role( 'editor' );
 
@@ -31 +31 @@
     }
 
-    function test_invalid_taxonomy() {
+    public function test_invalid_taxonomy() {
         $this->make_user_by_role( 'editor' );
 
@@ -40 +40 @@
     }
 
-    function test_incapable_user() {
+    public function test_incapable_user() {
         $this->make_user_by_role( 'subscriber' );
 
@@ -49 +49 @@
     }
 
-    function test_empty_term() {
+    public function test_empty_term() {
         $this->make_user_by_role( 'editor' );
 
@@ -68 +68 @@
     }
 
-    function test_parent_for_nonhierarchical() {
+    public function test_parent_for_nonhierarchical() {
         $this->make_user_by_role( 'editor' );
 
@@ -88 +88 @@
     }
 
-    function test_parent_invalid() {
+    public function test_parent_invalid() {
         $this->make_user_by_role( 'editor' );
 
@@ -107 +107 @@
     }
 
-    function test_parent_not_existing() {
+    public function test_parent_not_existing() {
         $this->make_user_by_role( 'editor' );
 
@@ -128 +128 @@
 
 
-    function test_add_term() {
-        $this->make_user_by_role( 'editor' );
-
-        $result = $this->myxmlrpcserver->wp_newTerm(
-            array(
-                1,
-                'editor',
-                'editor',
-                array(
-                    'taxonomy' => 'category',
-                    'name'     => 'test',
-                ),
-            )
-        );
-        $this->assertNotIXRError( $result );
-        $this->assertStringMatchesFormat( '%d', $result );
-    }
-
-    function test_add_term_with_parent() {
+    public function test_add_term() {
+        $this->make_user_by_role( 'editor' );
+
+        $result = $this->myxmlrpcserver->wp_newTerm(
+            array(
+                1,
+                'editor',
+                'editor',
+                array(
+                    'taxonomy' => 'category',
+                    'name'     => 'test',
+                ),
+            )
+        );
+        $this->assertNotIXRError( $result );
+        $this->assertStringMatchesFormat( '%d', $result );
+    }
+
+    public function test_add_term_with_parent() {
         $this->make_user_by_role( 'editor' );
 
@@ -165 +165 @@
     }
 
-    function test_add_term_with_all() {
+    public function test_add_term_with_all() {
         $this->make_user_by_role( 'editor' );