Changeset 52019

Timestamp:

11/05/2021 12:17:32 PM (3 years ago)

Author:

hellofromTonya

Message:

Code Modernization: Pass correct default value to http_build_query() in get_core_checksums() and wp_version_check().

The get_core_checksums() and wp_version_check() functions call the PHP native http_build_query() function, the second parameter of which is the optional $numeric_prefix parameter which expects a non-nullable string.

A parameter being optional, however, does not automatically make it nullable.

As of PHP 8.1, passing null to a non-nullable PHP native function will generate a deprecation notice.

In this case, this function call yielded a http_build_query(): Passing null to parameter #2 ($numeric_prefix) of type string is deprecated notice.

Changing the null to an empty string fixes this without a backward compatibility break.

References:

• ​PHP Manual: http_build_query()
• ​PHP RFC: Deprecate passing null to non-nullable arguments of internal functions

Follow-up to [18697], [25540].

Props bjorsch, kraftbj, hellofromTonya, jrf.
See #54229.

Location:

trunk/src

Files:

• wp-admin/includes/update.php (modified) (1 diff)
• wp-includes/update.php (modified) (1 diff)

trunk/src/wp-admin/includes/update.php

@@ -121 +121 @@
  */
 function get_core_checksums( $version, $locale ) {
-    $http_url = 'http://api.wordpress.org/core/checksums/1.0/?' . http_build_query( compact( 'version', 'locale' ), null, '&' );
+    $http_url = 'http://api.wordpress.org/core/checksums/1.0/?' . http_build_query( compact( 'version', 'locale' ), '', '&' );
     $url      = $http_url;
 

trunk/src/wp-includes/update.php

@@ -144 +144 @@
     }
 
-    $url      = 'http://api.wordpress.org/core/version-check/1.7/?' . http_build_query( $query, null, '&' );
+    $url      = 'http://api.wordpress.org/core/version-check/1.7/?' . http_build_query( $query, '', '&' );
     $http_url = $url;
     $ssl      = wp_http_supports( array( 'ssl' ) );