Changeset 52020

Timestamp:

11/05/2021 05:57:40 PM (3 years ago)

Author:

SergeyBiryukov

Message:

Coding Standards: Consistently escape attribute in wp-admin/themes.php.

Follow-up to [27012], [38057], [47816], [51083].

Props sabbirshouvo, audrasjb.
Fixes #54256.

File:

• trunk/src/wp-admin/themes.php (modified) (8 diffs)

trunk/src/wp-admin/themes.php

@@ -364 +364 @@
 
 foreach ( $themes as $theme ) :
-    $aria_action = esc_attr( $theme['id'] . '-action' );
-    $aria_name   = esc_attr( $theme['id'] . '-name' );
+    $aria_action = $theme['id'] . '-action';
+    $aria_name   = $theme['id'] . '-name';
 
     $active_class = '';
@@ -375 +375 @@
     <?php if ( ! empty( $theme['screenshot'][0] ) ) { ?>
         <div class="theme-screenshot">
-            <img src="<?php echo $theme['screenshot'][0]; ?>" alt="" />
+            <img src="<?php echo esc_attr( $theme['screenshot'][0] ); ?>" alt="" />
         </div>
     <?php } else { ?>
@@ -509 +509 @@
     $details_aria_label = sprintf( _x( 'View Theme Details for %s', 'theme' ), $theme['name'] );
     ?>
-    <button type="button" aria-label="<?php echo esc_attr( $details_aria_label ); ?>" class="more-details" id="<?php echo $aria_action; ?>"><?php _e( 'Theme Details' ); ?></button>
+    <button type="button" aria-label="<?php echo esc_attr( $details_aria_label ); ?>" class="more-details" id="<?php echo esc_attr( $aria_action ); ?>"><?php _e( 'Theme Details' ); ?></button>
     <div class="theme-author">
         <?php
@@ -519 +519 @@
     <div class="theme-id-container">
         <?php if ( $theme['active'] ) { ?>
-            <h2 class="theme-name" id="<?php echo $aria_name; ?>">
+            <h2 class="theme-name" id="<?php echo esc_attr( $aria_name ); ?>">
                 <span><?php _ex( 'Active:', 'theme' ); ?></span> <?php echo $theme['name']; ?>
             </h2>
         <?php } else { ?>
-            <h2 class="theme-name" id="<?php echo $aria_name; ?>"><?php echo $theme['name']; ?></h2>
+            <h2 class="theme-name" id="<?php echo esc_attr( $aria_name ); ?>"><?php echo $theme['name']; ?></h2>
         <?php } ?>
 
@@ -900 +900 @@
                     $aria_label = sprintf( _x( 'Activate %s', 'theme' ), '{{ data.name }}' );
                     ?>
-                    <a class="button activate" href="{{{ data.actions.activate }}}" aria-label="<?php echo $aria_label; ?>"><?php _e( 'Activate' ); ?></a>
+                    <a class="button activate" href="{{{ data.actions.activate }}}" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _e( 'Activate' ); ?></a>
                     <?php
                     /* translators: %s: Theme name. */
@@ -1118 +1118 @@
                     ?>
                     <# if ( data.actions.activate ) { #>
-                        <a href="{{{ data.actions.activate }}}" class="button activate" aria-label="<?php echo $aria_label; ?>"><?php _e( 'Activate' ); ?></a>
+                        <a href="{{{ data.actions.activate }}}" class="button activate" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _e( 'Activate' ); ?></a>
                     <# } #>
                     <a href="{{{ data.actions.customize }}}" class="button button-primary load-customize hide-if-no-customize"><?php _e( 'Live Preview' ); ?></a>
@@ -1127 +1127 @@
                     ?>
                     <# if ( data.actions.activate ) { #>
-                        <a class="button disabled" aria-label="<?php echo $aria_label; ?>"><?php _ex( 'Cannot Activate', 'theme' ); ?></a>
+                        <a class="button disabled" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _ex( 'Cannot Activate', 'theme' ); ?></a>
                     <# } #>
                     <a class="button button-primary hide-if-no-customize disabled"><?php _e( 'Live Preview' ); ?></a>
@@ -1138 +1138 @@
                 $aria_label = sprintf( _x( 'Delete %s', 'theme' ), '{{ data.name }}' );
                 ?>
-                <a href="{{{ data.actions['delete'] }}}" class="button delete-theme" aria-label="<?php echo $aria_label; ?>"><?php _e( 'Delete' ); ?></a>
+                <a href="{{{ data.actions['delete'] }}}" class="button delete-theme" aria-label="<?php echo esc_attr( $aria_label ); ?>"><?php _e( 'Delete' ); ?></a>
             <# } #>
         </div>