Changeset 52030

Timestamp:

11/07/2021 10:08:55 PM (3 years ago)

Author:

joedolson

Message:

Editor: Update structure of title element for editing.

Re-format the title element for post editing to follow general scheme for WordPress admin screens.

Props SergeyBiryukov.
Fixes #52314.

File:

• trunk/src/wp-admin/admin-header.php (modified) (2 diffs)

trunk/src/wp-admin/admin-header.php

@@ -50 +50 @@
     $admin_title = sprintf( __( '%s — WordPress' ), $title );
 } else {
+    $screen_title = $title;
+
+    if ( 'post' === $current_screen->base && 'add' !== $current_screen->action ) {
+        $post_title = get_the_title();
+        if ( ! empty( $post_title ) ) {
+            $post_type_obj = get_post_type_object( $typenow );
+            $screen_title  = sprintf(
+                /* translators: Editor admin screen title. 1: "Edit item" text for the post type, 2: Post title. */
+                __( '%1$s “%2$s”' ),
+                $post_type_obj->labels->edit_item,
+                $post_title
+            );
+        }
+    }
+
     /* translators: Admin screen title. 1: Admin screen name, 2: Network or site name. */
-    $admin_title = sprintf( __( '%1$s ‹ %2$s — WordPress' ), $title, $admin_title );
+    $admin_title = sprintf( __( '%1$s ‹ %2$s — WordPress' ), $screen_title, $admin_title );
 }
 
@@ -57 +72 @@
     /* translators: %s: Admin screen title. */
     $admin_title = sprintf( __( 'Recovery Mode — %s' ), $admin_title );
-}
-
-if ( 'post' === $current_screen->base && 'add' !== $current_screen->action ) {
-    $post_title = get_the_title();
-    if ( ! empty( $post_title ) ) {
-        $obj = get_post_type_object( $typenow );
-        /* translators: Editor admin screen title. 1: "Edit item" text for the post type, 2: Post title. */
-        $admin_title = sprintf( __( '%1$s “%2$s”' ), $obj->labels->edit_item, $post_title );
-    }
 }