Changeset 52031 for trunk/src/wp-includes/widgets/class-wp-widget-rss.php

Timestamp:

11/07/2021 11:03:47 PM (5 years ago)

Author:

joedolson

Message:

Widgets: Add filter to disable RSS widget icon.

Add a filter that disables output of the icon on RSS feed widgets. Improves accessibility by providing a path to prevent duplicate or invisible links.

Props sabernhardt, Boniu91.
Fixes #52224.

File:

• trunk/src/wp-includes/widgets/class-wp-widget-rss.php (modified) (1 diff)

trunk/src/wp-includes/widgets/class-wp-widget-rss.php

@@ -87 +87 @@
                 $title = apply_filters( 'widget_title', $title, $instance, $this->id_base );
 
-                $url  = strip_tags( $url );
-                $icon = includes_url( 'images/rss.png' );
                 if ( $title ) {
-                        $title = '<a class="rsswidget" href="' . esc_url( $url ) . '"><img class="rss-widget-icon" style="border:0" width="14" height="14" src="' . esc_url( $icon ) . '" alt="RSS" /></a> <a class="rsswidget" href="' . esc_url( $link ) . '">' . esc_html( $title ) . '</a>';
+                        $feed_link = '';
+                        $feed_url  = strip_tags( $url );
+                        $feed_icon = includes_url( 'images/rss.png' );
+                        $feed_link = sprintf(
+                                '<a class="rsswidget rss-widget-feed" href="%1$s"><img class="rss-widget-icon" style="border:0" width="14" height="14" src="%2$s" alt="%3$s"%4$s /></a> ',
+                                esc_url( $feed_url ),
+                                esc_url( $feed_icon ),
+                                esc_attr__( 'RSS' ),
+                                ( wp_lazy_loading_enabled( 'img', 'rss_widget_feed_icon' ) ? ' loading="lazy"' : '' )
+                        );
+
+                        /**
+                         * Filters the classic RSS widget's feed icon link.
+                         *
+                         * Themes can remove the icon link by using `add_filter( 'rss_widget_feed_link', '__return_false' );`.
+                         *
+                         * @since 5.9.0
+                         *
+                         * @param string $feed_link HTML for link to RSS feed.
+                         * @param array  $instance  Array of settings for the current widget.
+                         */
+                        $feed_link = apply_filters( 'rss_widget_feed_link', $feed_link, $instance );
+
+                        $title = $feed_link . '<a class="rsswidget rss-widget-title" href="' . esc_url( $link ) . '">' . esc_html( $title ) . '</a>';
                 }