Changeset 52042 for trunk/src/wp-includes/blocks/query-pagination-numbers.php

Timestamp:

11/08/2021 02:26:27 PM (3 years ago)

Author:

youknowriad

Message:

Block Editor: Update the WordPress Packages based on Gutenberg 11.9 RC1.

This brings the JS packages up to date and is the first step that will allow us
to include the other block editor updates for WordPress 5.9:
FSE infrastrucutre, site editor and global styles.

Props noisysocks.
See #54337.

File:

• trunk/src/wp-includes/blocks/query-pagination-numbers.php (modified) (1 diff)

trunk/src/wp-includes/blocks/query-pagination-numbers.php

@@ -46 +46 @@
             'prev_next' => false,
         );
+        if ( 1 !== $page ) {
+            /**
+             * `paginate_links` doesn't use the provided `format` when the page is `1`.
+             * This is great for the main query as it removes the extra query params
+             * making the URL shorter, but in the case of multiple custom queries is
+             * problematic. It results in returning an empty link which ends up with
+             * a link to the current page.
+             *
+             * A way to address this is to add a `fake` query arg with no value that
+             * is the same for all custom queries. This way the link is not empty and
+             * preserves all the other existent query args.
+             *
+             * @see https://developer.wordpress.org/reference/functions/paginate_links/
+             *
+             * The proper fix of this should be in core. Track Ticket:
+             * @see https://core.trac.wordpress.org/ticket/53868
+             *
+             * TODO: After two WP versions (starting from the WP version the core patch landed),
+             * we should remove this and call `paginate_links` with the proper new arg.
+             */
+            $paginate_args['add_args'] = array( 'cst' => '' );
+        }
         // We still need to preserve `paged` query param if exists, as is used
         // for Queries that inherit from global context.